Skip to content

fix LLVM easyconfigs as required by revamped custom easyblock for LLVM + add lit and git as build dependencies#20902

Merged
boegel merged 48 commits intoeasybuilders:5.0.xfrom
Crivella:feature-LLVM_unified
Mar 8, 2025
Merged

fix LLVM easyconfigs as required by revamped custom easyblock for LLVM + add lit and git as build dependencies#20902
boegel merged 48 commits intoeasybuilders:5.0.xfrom
Crivella:feature-LLVM_unified

Conversation

@Crivella
Copy link
Copy Markdown
Contributor

@Crivella Crivella commented Jun 25, 2024

EC files to compile LLVMcore (clang + flang-new + optional projects)

More notes on the EB PR

Comment thread easybuild/easyconfigs/l/LLVM/LLVM-18.1.8.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2024

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902"

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20902 EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20902 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13985

Test results coming soon (I hope)...

Details

- notification for comment with ID 2260799985 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Crivella
Copy link
Copy Markdown
Contributor Author

@boegel
Is it normal the job has been there for 2 weeks? Just to make sure the build process is not stuck somewhere and wasting resources

@branfosj
Copy link
Copy Markdown
Member

ERROR: Missing dependencies: lit/18.1.2-GCCcore-12.2.0, git/2.42-GCCcore-13.2.0 (no easyconfig file or existing module found)

@Crivella
Copy link
Copy Markdown
Contributor Author

@branfosj Thanks! I've fixed this with 6d35631

@branfosj
Copy link
Copy Markdown
Member

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902"

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=20902 EB_ARGS="--include-easyblocks-from-pr 3373 --installpath /tmp/$USER/pr20902" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20902 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14052

Test results coming soon (I hope)...

Details

- notification for comment with ID 2285756812 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3373
FAILED
Build succeeded for 16 out of 21 (21 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5d2fa9a94fea54443c6efb24cd74661b for a full test report.

boegel
boegel previously approved these changes Mar 7, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensively tested with easybuilders/easybuild-easyblocks#3373, so time to finally merge this.

@Crivella Thanks a lot for all your efforts on this, and sorry for the holdup...

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2025

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3373
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3506.doduo.os - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/70a222efa6817f148396e32fc363682a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2025

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3623.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/b9cd59dc76efb68f646ec1d12d6b9328 for a full test report.

@Crivella
Copy link
Copy Markdown
Contributor Author

Crivella commented Mar 7, 2025

I think the failure in the CI was due to Mesa-24.1.3 depending on LLVM-18.1.8-GCCcore-13.3.0 which has now been suffixed with minimal

I've updated the dependency in 66b29d9

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Mar 7, 2025

Is there a reason why we have both easybuild/easyconfigs/l/lit/lit-18.1.7-GCCcore-13.3.0.eb and easybuild/easyconfigs/l/lit/lit-18.1.8-GCCcore-13.3.0.eb for GCCcore/13.3.0? easybuild/easyconfigs/l/LLVM/LLVM-18.1.8-GCCcore-13.3.0-minimal.eb is only using the latter.

@Crivella
Copy link
Copy Markdown
Contributor Author

Crivella commented Mar 7, 2025

Umh, i think it is a leftover from the fact that i first build around 18.1.7 and than updated to 18.1.8.
It does not seems to still be used so it can probably be removed (or just left there in case someone would ever want it)

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3623.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/0582b42046cb9eb598a4df265fce6ba4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2025

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3621.doduo.os - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/e20a5f3be17311f8a26729d9a55ca585 for a full test report.

@boegel boegel added this to the 5.0.0 milestone Mar 8, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2025

Going in, thanks @Crivella!

@boegel boegel merged commit a90842d into easybuilders:5.0.x Mar 8, 2025
@boegel boegel removed this from EasyBuild v5.0 Mar 8, 2025
@Crivella Crivella deleted the feature-LLVM_unified branch March 10, 2025 09:13
Crivella added a commit to Crivella/easybuild-easyconfigs that referenced this pull request Mar 10, 2025
@Flamefire
Copy link
Copy Markdown
Contributor

Was it an intended change to remove build_shared_libs from the GCCcore 10.3 toolchains or an oversight? It breaks the Mesa build for me

@Crivella
Copy link
Copy Markdown
Contributor Author

Crivella commented Apr 7, 2025

@Flamefire Might be unintended, or atleast i do not remember having particular problem with old builds that would've caused em to disable it.

@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Apr 7, 2025

Was it an intended change to remove build_shared_libs from the GCCcore 10.3 toolchains or an oversight? It breaks the Mesa build for me

Given that LLVM 14.x.x+ still have build_shared_libs, I'd guess that this was just an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants