Skip to content

Re-add build of shared libs for LLVM [GCCcore 10.3.0]#22720

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
Flamefire:20250407103658_new_pr_LLVM1110
Apr 7, 2025
Merged

Re-add build of shared libs for LLVM [GCCcore 10.3.0]#22720
branfosj merged 1 commit intoeasybuilders:developfrom
Flamefire:20250407103658_new_pr_LLVM1110

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Apr 7, 2025

(created using eb --new-pr)

This was (likely accidentally) removed in #20902
CC @Crivella

@github-actions github-actions Bot added the change label Apr 7, 2025
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Apr 7, 2025

Yeah probably unintended, should be a quick (~20min) test to see if it compiles with as this is only a minimal build

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 7, 2025

@boegelbot please test @ jsc-zen3

@branfosj branfosj added bug fix and removed change labels Apr 7, 2025
@branfosj branfosj added this to the release after 5.0.0 milestone Apr 7, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22720 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22720 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6125

Test results coming soon (I hope)...

Details

- notification for comment with ID 2782508401 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm jfgrimm changed the title Readd build of shared libs for LLVM [GCCcore 10.3.0] Re-add build of shared libs for LLVM [GCCcore 10.3.0] Apr 7, 2025
@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
login1 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/a9a0cbf1800692dd095c7c9a8f530401 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
julia.hpc.tu-dresden.de - Linux Rocky Linux 8.7 (Green Obsidian), x86_64, Intel(R) Xeon(R) Platinum 8276M CPU @ 2.20GHz (cascadelake), Python 3.8.13
See https://gist.github.com/Flamefire/d2cb6030ae5949a54f84305ad431bac8 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 7, 2025

Test report by @branfosj
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/7199c6e2e8c2c9a779bbe3009e4db57f for a full test report.

FAIL: LLVM :: Bindings/Go/go.test (6288 of 38447)
******************** TEST 'LLVM :: Bindings/Go/go.test' FAILED ********************
Script:
--
: 'RUN: at line 1';   /dev/shm/branfosj/build-up-EL8/LLVM/11.1.0/GCCcore-10.3.0/llvm.obj.1/bin/llvm-go go=/usr/bin/go test llvm.org/llvm/bindings/go/llvm
--
Exit Code: 1

Command Output (stderr):
--
no required module provides package llvm.org/llvm/bindings/go/llvm: go.mod file not found in current directory or any parent directory; see 'go help modules'

--

********************

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Apr 7, 2025

Seems to be tha same failing test we saw in another PR, kinda curios to get a full log to see what is happening, we should probably start ignoring this in all the old minimal builds?

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/3e8b0fe4ad8e71bf545e58bec1a66ee8 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 7, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/62aa0acb5c2e777308a81dd9b3b676c2 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 7, 2025

Seems to be tha same failing test we saw in another PR, kinda curios to get a full log to see what is happening, we should probably start ignoring this in all the old minimal builds?

See https://gist.github.com/branfosj/8a0036b31cc25d57e6bfe4abc1a1d266

And that has

Go bindings enabled.

I am not sure what is checked to enable that.

I have go on installed on that node - I'm not sure why it is there - and it is detected by LLVM. I'll test that by building on the other node, that does not have go.

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Apr 7, 2025

Guess this is ON by default
https://github.com/llvm/llvm-project/blob/fed41342a82f5a3a9201819a82bf7a48313e296b/llvm/CMakeLists.txt#L557
can probably disable it in the easyblock (the option seems to have been removed in LLVM 16).

Probably some weird interaction with system deps, as it is not something that i think any package was relying on i think we can safely disable that test for LLVM < 16.0.0, gonna open an issue and a PR

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 7, 2025

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 7, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/765611e20ee2c5f9b1567e6c45533668 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 7, 2025

Going in, thanks @Flamefire!

@branfosj branfosj merged commit 53665e4 into easybuilders:develop Apr 7, 2025
8 checks passed
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Apr 7, 2025

Added a comment for it in the PR easybuilders/easybuild-easyblocks#3690
Would still first try to see if just disabling the test works. As that variable controls multiple bindings i find it tricky to leverage it. After v16 it actually controls only the Ocaml bindings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants