Skip to content

move netCDF to last dependency in 2022* GDAL easyconfigs, to make sure correct netcdf.h is picked up (not the one included in HDF dependency)#25683

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20260407155951_new_pr_GDAL350
Apr 7, 2026
Merged

move netCDF to last dependency in 2022* GDAL easyconfigs, to make sure correct netcdf.h is picked up (not the one included in HDF dependency)#25683
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20260407155951_new_pr_GDAL350

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Apr 7, 2026 •
edited
Loading

(created using eb --new-pr)

Followup to #24883

Even though 2022 toolchains are deprecated this is a trivial fix for something which was likely a regression making those ECs unable to be built

@Flamefire
move netCDF to last dependency in 2022 GDAL easyconfigs, to make sure…
cdcaab5 
… correct netcdf.h is picked up (not the one included in HDF dependency)
@Thyre Thyre added bug fix and removed change labels Apr 7, 2026
@github-actions github-actions Bot added the change label Apr 7, 2026
@Flamefire Flamefire mentioned this pull request Apr 7, 2026
Merged
1 task
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 7, 2026

Test report by @Flamefire
SUCCESS
Build succeeded for 24 out of 24 (total: 1 hour 13 mins 55 secs) (2 easyconfigs in total)
c119 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 9334 32-Core Processor (zen4), 4 x NVIDIA NVIDIA H100, 580.65.06, Python 3.9.21
See https://gist.github.com/Flamefire/7bab16f1b4fab23237ff0fb96cc5e3e0 for a full test report.

@boegel boegel removed the change label Apr 7, 2026
@boegel boegel added this to the next release (5.3.0) milestone Apr 7, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 7, 2026

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 7, 2026

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25683 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25683 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10140

Test results coming soon (I hope)...

Details

- notification for comment with ID 4200953468 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 7, 2026

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (total: 30 mins 20 secs) (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/389bda3faaef2063af705fe3085b86d7 for a full test report.

@boegel boegel changed the title move netCDF to last dependency in 2022 GDAL easyconfigs, to make sure correct netcdf.h is picked up (not the one included in HDF dependency) move netCDF to last dependency in 2022 GDAL easyconfigs, to make sure correct netcdf.h is picked up (not the one included in HDF dependency) Apr 7, 2026
boegel
boegel approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 7, 2026

Going in, thanks @Flamefire!

@boegel boegel merged commit be09959 into easybuilders:develop Apr 7, 2026
6 checks passed
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 7, 2026

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (total: 42 mins 13 secs) (2 easyconfigs in total)
i7064 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/Flamefire/3deb33950602938b47bf2c1ad089e6bf for a full test report.

@Flamefire Flamefire deleted the 20260407155951_new_pr_GDAL350 branch April 7, 2026 18:46
@boegel boegel changed the title move netCDF to last dependency in 2022 GDAL easyconfigs, to make sure correct netcdf.h is picked up (not the one included in HDF dependency) move netCDF to last dependency in 2022* GDAL easyconfigs, to make sure correct netcdf.h is picked up (not the one included in HDF dependency) Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

2022a 2022b bug fix

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @boegel @boegelbot @Thyre