Skip to content

Use env wherever preconfigopts is used to set environmental vars#2807

Merged
boegel merged 1 commit intoeasybuilders:developfrom
riccardomurri:use-env-in-preconfigopts
Mar 31, 2016
Merged

Use env wherever preconfigopts is used to set environmental vars#2807
boegel merged 1 commit intoeasybuilders:developfrom
riccardomurri:use-env-in-preconfigopts

Conversation

@riccardomurri
Copy link
Copy Markdown
Contributor

@riccardomurri riccardomurri commented Mar 30, 2016

Without env, we are relying on a syntactical feature of Bourne-type
shells; the env utility guarantees that the command-line will continue
to work even with other shells (e.g., tcsh).

@riccardomurri
Use env wherever `preconfigopts is used to set environmental variab…
96afcdd 
…les.

Without `env`, we are relying on a syntactical feature of Bourne-type
shells; the `env` utility guarantees that the command-line will continue
to work even with other shells (e.g., `tcsh`).
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 30, 2016

Automatic reply from Jenkins: Can I test this?

@riccardomurri
Copy link
Copy Markdown
Contributor Author

riccardomurri commented Mar 30, 2016

For the record, here are the command incantations used to patch all
.eb files in one go::

    # list all `preconfig="VAR=..."` and `preconfig += "VAR=..."` lines
    find -name '*.eb' | xargs egrep -i 'preconfigopts\s*\+?=\s*['\''"]\s*[A-Z]+='

    # turn `preconfig = "VAR=..."` into `preconfig += "env VAR=..."`
    find -name '*.eb' | xargs sed -re 's/preconfigopts\s*(\+?=)\s*(['\''"])\s*([A-Z]+=)/preconfigopts \1 \2env \3/' -i

@riccardomurri riccardomurri changed the title Use env wherever `preconfigopts is used to set environmental vars Use env wherever preconfigopts is used to set environmental vars Mar 30, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

Jenkins: ok to test

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

@riccardomurri up for doing the same for prebuildopts and preinstallopts? In a separate PR please, this is big enough as is...

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 31, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7251/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
daint103 - Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.9
See https://gist.github.com/57222e3921d31779751a133cce6304c5 for a full test report.

This was referenced Mar 31, 2016
Merged
Merged
@boegel boegel added this to the v2.8.0 milestone Mar 31, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

retested most of these easyconfigs, no problems whatsoever encountered, so going in

Thanks @riccardomurri!

@boegel boegel merged commit 67f66bd into easybuilders:develop Mar 31, 2016
This was referenced Apr 10, 2016
Merged
Merged
@boegel boegel mentioned this pull request Apr 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@riccardomurri @hpcugentbot @boegel