Skip to content

Use env wherever `prebuildopts is used to set environmental variables.#2811

Merged
boegel merged 3 commits intoeasybuilders:developfrom
riccardomurri:use-env-in-prebuildopts
Apr 1, 2016
Merged

Use env wherever `prebuildopts is used to set environmental variables.#2811
boegel merged 3 commits intoeasybuilders:developfrom
riccardomurri:use-env-in-prebuildopts

Conversation

@riccardomurri
Copy link
Copy Markdown
Contributor

As requested by @boegel in PR #2807

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

Jenkins: ok to test

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

@riccardomurri we have a single instance of this for preinstallopts too:

./easybuild/easyconfigs/p/p4vasp/p4vasp-0.3.29-intel-2016a-Python-2.7.11.eb:preinstallopts = "HOME=%(installdir)s make local &&"

let's fix that in here too?

@boegel boegel added this to the v2.8.0 milestone Mar 31, 2016
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7262/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

@riccardomurri merging #2807 resulted in some conflicts here due to lines in context being modified, please resync with develop?

@riccardomurri riccardomurri force-pushed the use-env-in-prebuildopts branch from 48c8478 to ac6e72b Compare March 31, 2016 16:19
@riccardomurri
Copy link
Copy Markdown
Contributor Author

(Kenneth Hoste, Thu, Mar 31, 2016 at 09:06:10AM -0700:)

@riccardomurri merging #2807 resulted in some conflicts here due to
lines in context being modified, please resync with develop?

Done, but I had to do a push -f.

#preconfigopts = ' PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/lib64/pkgconfig/:/usr/share/pkgconfig" '

prebuildopts = 'CPATH="$EBROOTLIBDRM/include/libdrm" '
prebuildopts = 'env CPATH="$EBROOTLIBDRM/include/libdrm" '
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eek, I don't think we should be hard redefining $CPATH and totally ignore the current value here...

@riccardomurri fixed with riccardomurri#5

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7283/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

don't hard overwrite $CPATH in prebuildopts in Mesa easyconfig files
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7295/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

Test report by @boegel
FAILED
Build succeeded for 23 out of 24 (24 easyconfigs in this PR)
node2140.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/7ec69d8d854c2bf2c64e8546253bef70 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 1, 2016

Test report by @boegel
FAILED
Build succeeded for 23 out of 24 (24 easyconfigs in this PR)
node2116.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/3d60a829b870e66b0b0c19a2de64adfb for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 1, 2016

The issue with motif 2.2.4 with goolf/1.4.10 is not caused by the changes here, cfr. #2817.

Going in, thanks @riccardomurri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants