Skip to content

correct STAMP dependency in i-cisTarget, must be 1.3#3613

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:icistarget_stamp13
Sep 26, 2016
Merged

correct STAMP dependency in i-cisTarget, must be 1.3#3613
boegel merged 2 commits intoeasybuilders:developfrom
boegel:icistarget_stamp13

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 26, 2016

STAMP must be version 1.3 to ensure that a bugfix relevant to i-cisTarget is included, cfr. seqcode/stamp@9cdb232

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2677.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e5a24f6b6f24f2d149d44d40dabde08a for a full test report.


start_dir = 'src'

cmds_map = [('.*', "$CXX $CXXFLAGS -o stamp *.cpp -lm -lgsl -lgslcblas")]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$LDFLAGS (for GSL)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpoely86 Why? To ensure GSL is picked up from the right location? That's taken care of via $LIBRARY_PATH, no?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes and any other flags we give it there. If you compile without -c, add $LDFLAGS

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, sure

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2040.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/498e9e15286df6a39baed3ad92d04511 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2677.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/d8a5c9aa323147b6bfd2b87cab2335e0 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2040.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/44cf2609d9a4ec20475e4c22465e886c for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit f432e49 into easybuilders:develop Sep 26, 2016
@boegel boegel deleted the icistarget_stamp13 branch September 26, 2016 13:20
source_urls = ['https://github.com/seqcode/stamp/archive/']
sources = ['v%(version)s.tar.gz']

dependencies = [('GSL', '2.1')]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this was bumped to 2.2.1 in #3615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants