Skip to content

remove existing module file under --force/--rebuild#1933

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:force_remove_module
Sep 26, 2016
Merged

remove existing module file under --force/--rebuild#1933
boegel merged 1 commit intoeasybuilders:developfrom
boegel:force_remove_module

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 26, 2016

We are currently not removing the module file when a forced reinstall is being done.

That's problematic for a number of reasons:

  • while the installation is being performed, the existing module provides access to a partial (or empty) installation
  • if the installation fails somewhere halfway through, the module is still there even though the installation is partial/broken
  • when installing extensions, the existing module may get loaded rather than the temporary module that is generated when Lmod is used as a modules tool, which can cause problems in case dependencies have been tweaked (this occurred with correct STAMP dependency in i-cisTarget, must be 1.3 easybuild-easyconfigs#3613)

@boegel boegel added this to the v3.0 milestone Sep 26, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit afbe177 into easybuilders:develop Sep 26, 2016
@boegel boegel deleted the force_remove_module branch September 26, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants