Skip to content

add test to ensure there's only one variant for each dependency in dep graph of easyconfigs using particular toolchains (REVIEW)#5970

Merged
migueldiascosta merged 7 commits intoeasybuilders:developfrom
boegel:check_deps_per_toolchain_generation
Mar 13, 2018
Merged

add test to ensure there's only one variant for each dependency in dep graph of easyconfigs using particular toolchains (REVIEW)#5970
migueldiascosta merged 7 commits intoeasybuilders:developfrom
boegel:check_deps_per_toolchain_generation

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 7, 2018

No description provided.

@boegel
add test to ensure there's only one variant for each dependency in de…
80ffa3d 
…p graph of easyconfigs using particular toolchains
@boegel boegel added this to the 3.6.0 milestone Mar 7, 2018
@easybuilders easybuilders deleted a comment from boegelbot Mar 9, 2018
@easybuilders easybuilders deleted a comment from boegelbot Mar 11, 2018
This was referenced Mar 11, 2018
Merged
Merged
@boegel boegel changed the title add test to ensure there's only one variant for each dependency in dep graph of easyconfigs using particular toolchains (WIP) add test to ensure there's only one variant for each dependency in dep graph of easyconfigs using particular toolchains (REVIEW) Mar 11, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2018

I propose to fix the remaining violations that cause the newly added test to fail via changes implemented in #5993 and #5994 .

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 11, 2018

Travis test report: 7/7 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/352051482

Only showing partial log for 1st failed test suite run 8350.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/352051483

...
FAIL: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 236, in test_dep_versions_per_toolchain_generation
    self.assertFalse(multi_dep_vars, error_msg)
AssertionError: No multi-variant deps found for '^.*-(?P<tc_gen>201[89][ab]).*\.eb$' easyconfigs:

found 2 variants of 'gettext' dependency in easyconfigs using '2018a' toolchain generation
* version: 0.19.8.1; versionsuffix:  as dep for set(['git-2.16.1-foss-2018a.eb'])
* version: 0.19.8.1; versionsuffix: -libxml2-2.9.7 as dep for set(['Qt5-5.10.1-intel-2018a.eb', 'GObject-Introspection-1.54.1-foss-2018a-Python-2.7.14.eb'])

found 2 variants of 'hwloc' dependency in easyconfigs using '2018a' toolchain generation
* version: 1.11.7; versionsuffix:  as dep for set(['iomkl-2018a.eb', 'iompi-2018a.eb'])
* version: 1.11.8; versionsuffix:  as dep for set(['foss-2018a.eb', 'gompi-2018a.eb'])


----------------------------------------------------------------------
Ran 8555 tests in 538.982s

FAILED (failures=1)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

@boegel boegel mentioned this pull request Mar 12, 2018
Merged
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Mar 12, 2018

Re-trigger Travis

@vanzod vanzod closed this Mar 12, 2018
@vanzod vanzod reopened this Mar 12, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2018

@easybuilders/easybuild-easyconfigs-maintainers With #5993 and #5994 merged, this seems good to go...

migueldiascosta
migueldiascosta reviewed Mar 13, 2018
View reviewed changes
Comment thread test/easyconfigs/easyconfigs.py Outdated
return res

# restrict to checking dependencies of easyconfigs using common toolchains (start with 2018a)
for pattern in ['201[89][ab]', '20[29][0-9][ab]']:
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the second pattern be 20[2-9][0-9][ab]?

Comment thread test/easyconfigs/easyconfigs.py
res = True

elif len(dep_vars) == 2 and dep in ['Python', 'Tkinter']:
# for Python & Tkinter, it's OK to have on 2.x and one 3.x version
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/on 2/one 2/

migueldiascosta
migueldiascosta approved these changes Mar 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 13, 2018

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit dcf7983 into easybuilders:develop Mar 13, 2018
@boegel boegel deleted the check_deps_per_toolchain_generation branch March 13, 2018 08:44
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 13, 2018

🎉

This was referenced Mar 13, 2018
Merged
Merged
@boegel boegel mentioned this pull request Apr 8, 2018
Merged
@boegel boegel mentioned this pull request May 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @vanzod @migueldiascosta