Skip to content

use gettext 0.19.8.1 on top of libxml2 2.9.7 as dep for git built with foss/2018a#5993

Merged
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:git_2018a_fix_gettext_dep
Mar 12, 2018
Merged

use gettext 0.19.8.1 on top of libxml2 2.9.7 as dep for git built with foss/2018a#5993
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:git_2018a_fix_gettext_dep

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 11, 2018

This change is required to avoid that two different types of gettext are used as dependency in easyconfigs using a *-2018a toolchain, cfr. check being added in #5970 .

We usually refrain from updating dependencies in existing easyconfig files, but I consider it acceptable in this particular case.

This changes the git easyconfig contributed by @RvDijk in #5750, so it would be great to get some feedback from him on this change.

@boegel boegel added the change label Mar 11, 2018
@boegel boegel added this to the 3.6.0 milestone Mar 11, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2050.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5242c734915a97e33ab01df3dd6cedc4 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 11, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node2627.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5b2b9895213f2b2d701fa20256458a36 for a full test report.

@RvDijk
Copy link
Copy Markdown
Contributor

RvDijk commented Mar 12, 2018

Nice feature! Looks good to me w.r.t. the git easyconfig.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Mar 12, 2018

Test report by @vanzod
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 9.3, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/4cd5bc2d230a0c82e5a9717e17dff875 for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Mar 12, 2018

Going in, thanks @boegel!

@vanzod vanzod merged commit fd9c595 into easybuilders:develop Mar 12, 2018
@boegel boegel deleted the git_2018a_fix_gettext_dep branch March 12, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants