Skip to content

fix checksum for foreign extension in R 3.4.3 and R 3.4.4 easyconfigs#6245

Merged
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:R34_foreign_checksum
Apr 27, 2018
Merged

fix checksum for foreign extension in R 3.4.3 and R 3.4.4 easyconfigs#6245
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:R34_foreign_checksum

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 26, 2018

reported by @shahzebsiddiqui

This is the 2nd occurrence of changed checksums for R packages in a short amount of time (cfr. #6118), maybe it's time we raise this with CRAN somehow?

@boegel boegel added the bug fix label Apr 26, 2018
@boegel boegel added this to the 3.6.1 milestone Apr 26, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2591.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/bc3db19d8c19144ba667860117dc011a for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2073.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4a320e58927b191f65406a8b30c63e96 for a full test report.

@boegel boegel requested a review from vanzod April 27, 2018 14:41
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Apr 27, 2018

Going in, thanks @boegel!

@vanzod vanzod merged commit 00a4cb1 into easybuilders:develop Apr 27, 2018
@boegel boegel deleted the R34_foreign_checksum branch April 27, 2018 17:02
@shahzebsiddiqui
Copy link
Copy Markdown
Contributor

shahzebsiddiqui commented Apr 30, 2018

@boegel thanks for fixing this issue, I'd recommend we start cutting down on the number of R packages installed in the base install that is provided by foss and intel toolchain for subsequent versions of R. Providing checksums in easyconfigs become useless if these packages are updated frequently. The probability of just one package updating becomes high and cause the entire build to halt before doing the actual stuff.

@boegel boegel mentioned this pull request May 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanzod vanzod vanzod approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @vanzod @shahzebsiddiqui