Skip to content

fix typo in Nipype & NiBabel causing failure in test suite due to triggering typo detection#6261

Merged
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:exts_download_dep_fail_nibabel_nipype
May 2, 2018
Merged

fix typo in Nipype & NiBabel causing failure in test suite due to triggering typo detection#6261
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:exts_download_dep_fail_nibabel_nipype

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 2, 2018

This started occurring after easybuilders/easybuild-framework#2493 was merged:

ERROR: Test for parsing of easyconfig NiBabel-2.2.1-intel-2018a-Python-3.6.4.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 297, in template_easyconfig_test
    ecs = process_easyconfig(spec)
  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/easybuild_framework-3.6.1.dev0-py2.6.egg/easybuild/framework/easyconfig/easyconfig.py", line 1263, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
EasyBuildError: 'Failed to process easyconfig /home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/n/NiBabel/NiBabel-2.2.1-intel-2018a-Python-3.6.4.eb: You may have some typos in your easyconfig file: download_dep_fail -> exts_download_dep_fail'

======================================================================
ERROR: Test for parsing of easyconfig Nipype-1.0.2-intel-2018a-Python-3.6.4.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 1, in innertest
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 297, in template_easyconfig_test
    ecs = process_easyconfig(spec)
  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/easybuild_framework-3.6.1.dev0-py2.6.egg/easybuild/framework/easyconfig/easyconfig.py", line 1263, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
EasyBuildError: 'Failed to process easyconfig /home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/n/Nipype/Nipype-1.0.2-intel-2018a-Python-3.6.4.eb: You may have some typos in your easyconfig file: download_dep_fail -> exts_download_dep_fail'

----------------------------------------------------------------------
Ran 8867 tests in 265.390s

FAILED (errors=2)
ERROR: Not all tests were successful.

The errors produced are genuine: download_dep_fail is not a known easyconfig parameter in general (it will be a known custom one for the PythonPackage easyblock when easybuilders/easybuild-easyblocks#1377 gets merged), while exts_download_dep_fail is.

@boegel boegel added the bug fix label May 2, 2018
@boegel boegel added this to the 3.6.1 milestone May 2, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 2, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2411.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7878d989b33378d1969f22d264dd02ae for a full test report.

@boegel boegel mentioned this pull request May 2, 2018
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 2, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2065.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/1cf5607f686a91ba3a898a934929ab7e for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented May 2, 2018

Going in, thanks @boegel!

@vanzod vanzod merged commit 40ec75d into easybuilders:develop May 2, 2018
@boegel boegel deleted the exts_download_dep_fail_nibabel_nipype branch May 2, 2018 12:51
@vanzod vanzod mentioned this pull request May 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanzod vanzod vanzod approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.6.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @vanzod