add 'exts_download_dep_fail' as known easyconfig parameter#2493
Merged
wpoely86 merged 3 commits intoeasybuilders:developfrom May 2, 2018
Merged
add 'exts_download_dep_fail' as known easyconfig parameter#2493wpoely86 merged 3 commits intoeasybuilders:developfrom
wpoely86 merged 3 commits intoeasybuilders:developfrom
Conversation
… + minor style fixes to make flake8 happy
…/default.py, to avoid breaking 'eb -a'
wpoely86
reviewed
May 2, 2018
| globals().update(ALL_CATEGORIES) | ||
| CATEGORY_NAMES = ['BUILD', 'CUSTOM', 'DEPENDENCIES', 'EXTENSIONS', 'FILEMANAGEMENT', 'HIDDEN', | ||
| 'LICENSE', 'MANDATORY', 'MODULES', 'OTHER', 'TOOLCHAIN'] | ||
| ALL_CATEGORIES = dict((name, eval(name)) for name in CATEGORY_NAMES) |
Member
Author
There was a problem hiding this comment.
Because flake8 (rightfully) doesn't like us defining constants at runtime by injecting stuff into globals().
If you want me to, I can flesh this out in a separate PR.
wpoely86
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For easybuilders/easybuild-easyblocks#1377, so it leveraged for Python packages that are installed as extensions (e.g. via
Bundleeasyblock).This is required because variables defined in an easyconfig file that are not known easyconfig parameters are thrown away, and thus they can't be inherited by extensions...