Skip to content

{astro}[foss/2018b,intel/2018b] emcee v2.2.1#7989

Merged
akesandgren merged 3 commits intoeasybuilders:developfrom
jose-d:20190402134413_new_pr_emcee221
May 8, 2019
Merged

{astro}[foss/2018b,intel/2018b] emcee v2.2.1#7989
akesandgren merged 3 commits intoeasybuilders:developfrom
jose-d:20190402134413_new_pr_emcee221

Conversation

@jose-d
Copy link
Copy Markdown
Contributor

@jose-d jose-d commented Apr 2, 2019

(created using eb --new-pr)

dependency of ngmix I'd like to easybuildize too.

…2.1-intel-2018b-Python-2.7.15.eb, emcee-2.2.1-foss-2018b-Python-3.6.6.eb, emcee-2.2.1-intel-2018b-Python-3.6.6.eb
@jose-d
Copy link
Copy Markdown
Contributor Author

jose-d commented Apr 2, 2019

Test report by @jose-d
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
koios1 - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 2.7.5
See https://gist.github.com/8fc97af35cb41193dce5d2714c6e8ad0 for a full test report.

@jose-d
Copy link
Copy Markdown
Contributor Author

jose-d commented Apr 2, 2019

mhmm,

======================================================================
ERROR: test_conflicts (test.easyconfigs.easyconfigs.EasyConfigTest)
Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------

I'm not fully convinced that I have conflict there..

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 2, 2019

@jose-d You're definitely missing download_dep_fail = True (that's automatic for PythonBundle, not for PythonPackage).

The other issue is strange, looking into that...

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 2, 2019

@jose-d The problem with the failing conflicts test is a bug in framework, it's triggered by merging #7921 which relies on the new multi_deps feature implemented in easybuilders/easybuild-framework#2813, which apparently breaks --check-conflicts

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 2, 2019

@jose-d Bug is squashed in easybuilders/easybuild-framework#2825, the failing conflicts test should pass after that PR is merged and the tests are re-triggered (@vanzod: please follow up)

@vanzod vanzod closed this Apr 2, 2019
@easybuilders easybuilders deleted a comment from boegelbot Apr 2, 2019
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Apr 2, 2019

Re-trigger Travis after fix

@vanzod vanzod reopened this Apr 2, 2019
@easybuilders easybuilders deleted a comment from boegelbot Apr 2, 2019
@jose-d
Copy link
Copy Markdown
Contributor Author

jose-d commented Apr 2, 2019

@boegel:
perhaps we're lucky and found another one:

List of changed easyconfig files in this PR: emcee-2.2.1-foss-2018b-Python-2.7.15.eb
...
emcee-2.2.1-intel-2018b-Python-3.6.6.eb
.Conflict found for dependencies of SciPy-bundle-2019.03-foss-2019a: Python-2.7.15-GCCcore-8.2.0 vs Python-3.7.2-GCCcore-8.2.0 
	Python-2.7.15-GCCcore-8.2.0 as dep of: SciPy-bundle-2019.03-foss-2019a, SciPy-bundle-2019.03-intel-2019a

@easybuilders easybuilders deleted a comment from boegelbot Apr 3, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2019

@jose-d "Lucky" indeed... Problem was really fixed in easybuilders/easybuild-framework#2826

@jose-d jose-d closed this Apr 3, 2019
@jose-d jose-d reopened this Apr 3, 2019
@easybuilders easybuilders deleted a comment from boegelbot Apr 3, 2019
@easybuilders easybuilders deleted a comment from boegelbot Apr 3, 2019
@migueldiascosta migueldiascosta added this to the 3.x milestone Apr 12, 2019
@akesandgren akesandgren self-assigned this May 8, 2019
@akesandgren
Copy link
Copy Markdown
Contributor

Test report by @akesandgren
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in this PR)
b-an03.hpc2n.umu.se - Linux ubuntu 16.04, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/1af06802a6b3dcf9dcf3f65278524d7e for a full test report.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @jose-d!

@akesandgren akesandgren merged commit d1943ba into easybuilders:develop May 8, 2019
@akesandgren akesandgren modified the milestones: 3.x, next release (3.9.1) May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants