Skip to content

make check_conflicts aware of multi_deps#2826

Merged
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:fix_check_conflicts_multi_deps
Apr 3, 2019
Merged

make check_conflicts aware of multi_deps#2826
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:fix_check_conflicts_multi_deps

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 2, 2019

The change in #2825 was only sufficient to resolve the traceback/crash, but it left --check-conflicts broken when an easyconfig that uses multi_deps was in play:

eb --check-conflicts SciPy-bundle-2019.03-foss-2019a.eb
== temporary log file in case of crash /tmp/eb-G2OTHq/easybuild-lr7N39.log
Conflict found for dependencies of SciPy-bundle-2019.03-foss-2019a: Python-2.7.15-GCCcore-8.2.0 vs Python-3.7.2-GCCcore-8.2.0
	Python-2.7.15-GCCcore-8.2.0 as dep of: SciPy-bundle-2019.03-foss-2019a
	Python-3.7.2-GCCcore-8.2.0 as dep of: SciPy-bundle-2019.03-foss-2019a
ERROR: One or more conflicts detected!

Fixed with the changes included here:

eb --check-conflicts SciPy-bundle-2019.03-foss-2019a.eb
== temporary log file in case of crash /tmp/eb-LlOL8r/easybuild-oDMiU2.log

No conflicts detected!

== Temporary log file(s) /tmp/eb-LlOL8r/easybuild-oDMiU2.log* have been removed.
== Temporary directory /tmp/eb-LlOL8r has been removed.

@boegel boegel added the bug fix label Apr 2, 2019
@boegel boegel added this to the 3.9.0 milestone Apr 2, 2019
@boegel boegel requested a review from vanzod April 2, 2019 21:30
vanzod
vanzod approved these changes Apr 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vanzod vanzod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vanzod vanzod merged commit 183759f into easybuilders:develop Apr 3, 2019
@boegel boegel deleted the fix_check_conflicts_multi_deps branch April 3, 2019 05:07
This was referenced Apr 3, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanzod vanzod vanzod approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @vanzod