add intel/2014b toolchain definition, which includes GCC/4.8.3 as a dependency#948
Merged
boegel merged 2 commits intoeasybuilders:developfrom Jul 5, 2014
Merged
Conversation
Member
Author
There was a problem hiding this comment.
this is a conservative choice, maybe using the latest imkl v11.1.3.174 is also possible, I'm checking on that with Intel support
Member
Author
There was a problem hiding this comment.
reply from Intel support:
Intel compilers v13.1.x are officially supported by MKL 11.1.x. So yes, it is safe to use the latest MKL release with icc/ifort 2013.5.192.
However, when MKL 11.2 comes out later this year (Q4) and if you decide to use it then we'd strongly recommend you to update your compilers to v14.x. This is mainly because of OpenMP compatibility requirement. MKL 11.2 may have issues with OpenMP runtimes provided by compilers earlier than v14.
So, I'll update this PR to use the latest imkl version.
Member
Author
|
Jenkins: test this please |
1 similar comment
Member
Author
|
Jenkins: test this please |
|
We could maybe all agree on an environment variable to set to point to the intel license file? and if this is set don't try to do a default path. |
There was a problem hiding this comment.
os.path.expanduser("~") is prefered over os.getenv('HOME')
But actually I would prefer using something like an INTELLICENSEFILE environment variable...
Contributor
There was a problem hiding this comment.
On Wed, Jul 2, 2014 at 4:58 PM, Jens Timmerman [email protected]
wrote:
os.path.expanduser("~") is prefered over os.getenv('HOME')
Can you elaborate?
I have seen the opposite effect (situations where $HOME works, while ~
does not; no proof at the moment)
Member
Author
There was a problem hiding this comment.
the ~ approach is supposed to work on Windows too... I haven't seen that approach fail yet (It's used in a couple of places in EB).
Contributor
There was a problem hiding this comment.
In that case, I'd agree... let's have it as such and when it breaks we fix
it!
On 2 Jul 2014 17:03, "Kenneth Hoste" [email protected] wrote:
In easybuild/easyconfigs/i/imkl/imkl-11.0.5.192-GCC-4.8.3.eb:
+versionsuffix = '-%s-%s' % (gcc, gccver)
+
+# deps for interface build
+dependencies = [
- ('icc', compver, versionsuffix),
- ('ifort', compver, versionsuffix),
- ('impi', '4.1.3.049', versionsuffix),
+]
+dontcreateinstalldir = 'True'
+
+interfaces = True
+
+# license file
+import os
+license_file = os.path.join(os.getenv('HOME'), "licenses", "intel", "license.lic")the ~ approach is supposed to work on Windows too... I haven't seen that
approach fail yet (It's used in a couple of places in EB).—
Reply to this email directly or view it on GitHub
https://github.com/hpcugent/easybuild-easyconfigs/pull/948/files#r14461765
.
There was a problem hiding this comment.
@fgeorgatos python will expand ~ to $HOME if it is set, otherwise it will look the home dir up in /etc/passwd and also do other tricks on windows. So it is prefered.
Member
Author
There was a problem hiding this comment.
what we really need is a constant provided by the framework that points to the home directory, rather than importing os in an easyconfig file...
So let's fix it that way rather than switching to expanduser in here. Anyone up for that? @JensTimmerman?
Member
Author
|
@JensTimmerman: that's already covered in the |
|
Good enought for me then. |
Contributor
|
Seems fine. |
Member
Author
|
Test report by @boegel |
Member
Author
|
Merging this in after extensive testing; I've rebuilt all |
boegel
added a commit
that referenced
this pull request
Jul 5, 2014
add intel/2014b toolchain definition, which includes GCC/4.8.3 as a dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on easybuilders/easybuild-easyblocks#429 to ensure that FFTW wrappers libraries for Intel MKL are installed correctly
@gjbex, @hajgato, @JensTimmerman: please review?