properly quote GCC version string in archived easyconfig#1028
properly quote GCC version string in archived easyconfig#1028boegel merged 6 commits intoeasybuilders:developfrom
Conversation
|
@stdweird: please review? |
|
@boegel: Hmm... I'm still getting a parse error when trying to use the archived easyconfig for building (it says line 43, but it seems to be off by one, i.e., still in the |
|
I believe the quoting used by this PR is incorrect: But you know Python much better than I do... |
|
@geimer: hmm, damn... Seems like the |
|
@geimer: the issues indeed was't fixed properly, as also indicated by Jenkins (which is also running Debian), see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/917/console Last commit should now fix the problem properly (and also involves some code cleanup, hooray!)... Please check again? |
|
@geimer: make that the last two commits, a typo slipped in... |
|
@boegel: Not sure whether it will now work for all possible corner cases, but it works like a charm for my test case :-) Thanks! |
e92b89e to
5bec24f
Compare
|
@boegel ok to me |
properly quote GCC version string in archived easyconfig
I'm also renaming the archived easyconfigs here, to include the software name in the filename too (i.e. use
<repositorypath>/GCC/GCC-4.8.3.ebrather than<repositorypath>/GCC/4.8.3.eb@geimer: this should fix #961, please verify?