Skip to content

fix issue with --repositorypath not honoring --prefix#1031

Merged
boegel merged 7 commits intoeasybuilders:developfrom
boegel:fix_repopath_prefix
Sep 5, 2014
Merged

fix issue with --repositorypath not honoring --prefix#1031
boegel merged 7 commits intoeasybuilders:developfrom
boegel:fix_repopath_prefix

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 4, 2014

split off from #1028

@stdweird: please review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't repositorypath be processed before repository ? (and if so, make separate comment about it)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't matter, since repository isn't initialised here (as opposed to with the legacy config); the actual initialisation is done later when repository is configured via generaloption

@stdweird
Copy link
Copy Markdown
Contributor

stdweird commented Sep 5, 2014

@boegel looks a lot easier then previous PR. nice work!

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 5, 2014

Thanks for the review @stdweird!

boegel added a commit that referenced this pull request Sep 5, 2014
fix issue with --repositorypath not honoring --prefix
@boegel boegel merged commit 9772034 into easybuilders:develop Sep 5, 2014
@boegel boegel deleted the fix_repopath_prefix branch September 5, 2014 07:19
@stdweird
Copy link
Copy Markdown
Contributor

stdweird commented Sep 5, 2014

nvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants