fix $MODULEPATH extensions for Clang/CUDA, include versionsuffix in module subdir#1050
Merged
boegel merged 5 commits intoeasybuilders:developfrom Oct 6, 2014
Merged
Conversation
Member
There was a problem hiding this comment.
isn't using a regex here a bit overkill?
Member
Author
There was a problem hiding this comment.
How else would you do it?
This doesn't do what you may expect:
if ec['name'] in key:
...
Member
There was a problem hiding this comment.
but this does:
if ec['name'] in key.split(','):
As you use a split on L146, it's more consistent?
Member
|
I think this is fine but Jenkins disagrees? |
Member
Author
|
Jenkins: test this please |
Member
Author
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Oct 6, 2014
fix $MODULEPATH extensions for Clang/CUDA, include versionsuffix in module subdir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the open issues with using goolfc or cgoolf together with HierarchicalMNS, as discussed in easybuilders/easybuild-easyconfigs#1098 (reported by @kcgthb)
It also makes sure that the versionsuffix is included in the module subdir, which is important for e.g.
iccandifortincluded inintel/2014b, which have a-GCC-4.x.yversionsuffix.easybuilders/easybuild-easyconfigs#1106 is also required to fix the issues with
goolfc@wpoely86: please review?