don't override COMPILER_MODULE_NAME obtained from ClangGCC in Clang-based toolchains#1053
Merged
boegel merged 3 commits intoeasybuilders:developfrom Oct 6, 2014
Merged
don't override COMPILER_MODULE_NAME obtained from ClangGCC in Clang-based toolchains#1053boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
@wpoely86: please review |
Member
|
Looks fine, but Jenkins is unhappy? I think you have to change the tests too? |
Member
Author
|
@wpoely86: fixed |
Member
|
Looking good |
Member
Author
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Oct 6, 2014
don't override COMPILER_MODULE_NAME obtained from ClangGCC in Clang-based toolchains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
GCCandClangshould be first-class citizens of Clang-based toolchains; this is a strict requirements forHierarchicalMNS(see also #1050)