Skip to content

Added support for Parastation MPICH toolchains with Intel compilers#1072

Merged
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:intel-para
Dec 12, 2014
Merged

Added support for Parastation MPICH toolchains with Intel compilers#1072
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:intel-para

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Oct 24, 2014

Simple support for Parastation MPICH with intel compilers

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

Comment thread easybuild/toolchains/intel-para.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment here why you're overriding what is being set by IntelMKL?

is this a fix specific to Parastation?

also: you're including the 'generic' MPICH component here, yet naming the toolchain specifically for Parastation.

Maybe here we should be using:

class Impmkl(IntelIccIfort, Mpich, IntelMKL, IntelFFTW):
    NAME = 'impmkl'
    BLACS_LIB = [...]

and then on your end:

class IntelPara(Impmkl):
   NAME = 'intel-para'

I'm OK with including the 'empty' intel-para toolchain definition in the framework as well if that makes things easier for you

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the blacs fix is specific to Parastation or not. Perhaps it's best to put it in the empty toolchain

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 24, 2014

Jenkins: ok to test

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Oct 24, 2014

I've updated things so that generic patterns are created first and then wrapped with ParaStation specific extras.

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

2 similar comments
@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 3, 2014

@ocaisa: as far as I can tell, there are no easyconfigs yet for psmpi (although there are for psmpi2), impich, ipsmpi or intel-para. Is there a PR pending for that?
Everything looks OK in here, but it would be nice to have easyconfigs that can be used for testing this, i.e. an easyconfig for HPL with ipsmpi and everything below...

Comment thread easybuild/toolchains/intel-para.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocaisa: as discussed, this should be fixed in toolchains/linalg/intelmkl.py instead, since the MPICH2 value is now also wrong?

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Dec 11, 2014

Note https://software.intel.com/en-us/articles/intel-mkl-link-line-advisor to help figure out BLACS library for mpi implementation

@hpcugentbot
Copy link
Copy Markdown

Test FAILed.

@boegel boegel mentioned this pull request Dec 11, 2014
@boegel boegel merged commit 3e8677a into easybuilders:develop Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants