Ignore hidden directories when returning the finaldir#1413
Ignore hidden directories when returning the finaldir#1413boegel merged 4 commits intoeasybuilders:developfrom
Conversation
There was a problem hiding this comment.
don't use Dir, and dir is a keyword, so just use d (single-letter variables are fine in a list comprehension)
|
@wpoely86: let's enhance the unit tests too, maybe add a new test in test/framework/filetools.py dedicated to |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2122/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel please recheck |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2123/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2124/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Looks great now, I'm happy to see that writing a test made you catch a bug in your one-line change. ;-) Going in, thanks @wpoely86! |
Ignore hidden directories when returning the finaldir
No description provided.