fix guess_start_dir in case we're already in start_dir#1415
fix guess_start_dir in case we're already in start_dir#1415boegel merged 12 commits intoeasybuilders:developfrom
Conversation
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2127/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
print self.cfg['start_dir'] here as that is the dir that is actually specified?
There was a problem hiding this comment.
no, this error applies to the failing if os.path.exists(abs_start_dir), but I'll include an extra debug log message printing the start_dir we end up with
|
Can this not be done simpler by letting the extract_step not change the directory but simple setting the |
|
@wpoely86: you're working on a test for this? PR pending? |
New test to check the guess_start_dir
|
Btw, it can not be done simpler. This is probably the best solution. |
|
@wpoely86: I fleshed out the test you wrote a bit more, please rererereview? Should be good to go in otherwise, imho. |
|
looks good |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2135/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2136/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2173/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2174/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2176/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2177/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
add two absolute paths with and without overlap?
|
lgtm |
…ntation to make them pass ^_^
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2178/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks for the review @wpoely86! |
fix guess_start_dir in case we're already in start_dir
follow-up for #1413, since that was a non-backwards compatible change (I realised that the second after hitting the shiny green
Mergebutton)@wpoely86: can you review and maybe look into an enhanced unit test for this?