Skip to content

add support to specify alternative root/version for $EBROOT/$EBVERSION#1508

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:altrootver
Dec 13, 2015
Merged

add support to specify alternative root/version for $EBROOT/$EBVERSION#1508
boegel merged 3 commits intoeasybuilders:developfrom
boegel:altrootver

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 13, 2015

I need this to use in the Bundle easyblock, to make sure that $EBROOTGCC is defined correctly in the module generated for the GCC bundle that is part of easybuilders/easybuild-easyconfigs#2214.

@boegel boegel added this to the v2.5.0 milestone Dec 13, 2015
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 13, 2015

@wpoely86: please review

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2429/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2430/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc args

@wpoely86
Copy link
Copy Markdown
Member

lgtm

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2431/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 13, 2015

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Dec 13, 2015
add support to specify alternative root/version for $EBROOT/$EBVERSION
@boegel boegel merged commit cc7bb09 into easybuilders:develop Dec 13, 2015
@boegel boegel deleted the altrootver branch December 13, 2015 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants