Skip to content

add support for specifying altroot/altversion in Bundle easyblock#773

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:bundle_altrootver
Dec 14, 2015
Merged

add support for specifying altroot/altversion in Bundle easyblock#773
boegel merged 3 commits intoeasybuilders:developfrom
boegel:bundle_altrootver

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 13, 2015

@boegel boegel added this to the v2.5.0 milestone Dec 13, 2015
@boegel boegel mentioned this pull request Dec 13, 2015
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 13, 2015

@wpoely86: please review

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Dec 13, 2015

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1488/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

wpoely86
wpoely86 reviewed Dec 13, 2015
View reviewed changes
Comment thread easybuild/easyblocks/generic/bundle.py Outdated
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Dec 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we never do this? split it out in two lines.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Dec 13, 2015

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1489/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 13, 2015

Jenkins: test this please

@boegel boegel mentioned this pull request Dec 13, 2015
Merged
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Dec 13, 2015

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1491/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Dec 13, 2015

Easyblocks unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1492/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 14, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Dec 14, 2015

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1497/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 14, 2015

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Dec 14, 2015
@boegel
Merge pull request #773 from boegel/bundle_altrootver
592c303 
add support for specifying altroot/altversion in Bundle easyblock
@boegel boegel merged commit 592c303 into easybuilders:develop Dec 14, 2015
@boegel boegel deleted the bundle_altrootver branch December 14, 2015 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86