Skip to content

support providing additional relative path for prefix in external module metadata#1637

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:enhanced_metadata_external_modules
Feb 27, 2016
Merged

support providing additional relative path for prefix in external module metadata#1637
boegel merged 1 commit intoeasybuilders:developfrom
boegel:enhanced_metadata_external_modules

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 26, 2016

add support for entries like:

[fftw/3.3.4.3]
name = FFTW
version = 3.3.4.3
prefix = FFTW_INC/..

which results in $EBROOTFFTW being defined as the equivalent of $FFTW_INC/../ (if $FFTW_INC is defined)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2016

@gppezzi, @pforai, @wpoely86: review/feedback?

@hpcugentbot
Copy link
Copy Markdown

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2788/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Feb 27, 2016

Ideally Cray should fix that on their module files. But maybe they consider not setting a variable for fftw root as a feature, so it's good to be able to workaround that.

thx @boegel

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2016

Well, I'm guessing they wouldn't be willing to change existing module files...

And this is a useful feature regardless.

@wpoely86
Copy link
Copy Markdown
Member

looks good but maybe name it root instead of prefix to be consistent?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2016

@wpoely86: well, root is confusing (could mean the root user). You could argue the same for $EBROOT... of course, but there it's kind of clear from the context, I hope.

Also, we can't just rename that now, the support for providing metadata for external modules is not experimental by itself, that's a stable feature.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2016

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Feb 27, 2016
support providing additional relative path for prefix in external module metadata
@boegel boegel merged commit bd62e84 into easybuilders:develop Feb 27, 2016
@boegel boegel deleted the enhanced_metadata_external_modules branch February 27, 2016 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants