add external modules metadata for Cray systems#1638
add external modules metadata for Cray systems#1638boegel merged 14 commits intoeasybuilders:developfrom
Conversation
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2789/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
looks good! Now that we are arriving into final details: how much effort it would require to support versionless entries on the metadata file? that would avoid lots of copy&pasting when supporting other PE versions |
|
LGTM! |
|
@gppezzi: how would a versionless entry look like? |
|
how about: [fftw]
name = FFTW
prefix = FFTW_INC/..the metadata file would be much easier to maintain this way and the version would be needed only for exceptions (or when cray changes things for new versions) |
|
@gppezzi: we could take that one step further, and support something like: [fftw/%(version)s]
name = FFTW
version = %(version)s
prefix = FFTW_INC/..Just to also have the version info available (which is sometimes used in easyblocks for version checks on the dependencies). |
|
that looks pretty nice! |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2790/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@boegel can this work in a way that if you use explicit version it would override the entry with %(version)s? |
|
@gppezzi: it would have to, yes. But, I'd say we look into that in a future PR, since it doesn't add any extra feature or fixes an important bug. Let's focus on the other things required for stable Cray support first... So: please open an issue with this as a feature request. |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2791/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Issue opened #1639 As for this PR, I don' t have any other remarks. If this MD file is loaded by default then people should be able to easily try out the Cray TCs. |
…te parsed options
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2792/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2793/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
|
||
| parsed_metadata = ConfigObj() | ||
| for cfg in cfgs: | ||
| if os.path.exists(cfg): |
|
👍 |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2795/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
add external modules metadata for Cray systems
replaces #1586 and #1596
requires
#1637for the provided metadata to be handled correctly (cfr. the metadata forfftw)cc @pforai, @gppezzi