use '0' as letter dir for funky software names that don't start with a letter#1954
Merged
boegel merged 1 commit intoeasybuilders:developfrom Oct 10, 2016
Merged
use '0' as letter dir for funky software names that don't start with a letter#1954boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
wpoely86
reviewed
Oct 10, 2016
| """ | ||
| Determine 'letter' directory for specified software name. | ||
| This usually just the 1st letter of the software name (in lowercase), | ||
| except for funky software names, e.g. ones starting with a digit. |
Member
There was a problem hiding this comment.
why not use number instead of something like 4real or so?
Member
Author
There was a problem hiding this comment.
well, it should be a catch-all, I don't care how it's called exactly...
I can use _ instead?
wpoely86
approved these changes
Oct 10, 2016
wpoely86
approved these changes
Oct 10, 2016
Member
Author
|
Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this when looking into an easyconfig file to
3to2(required for easybuilders/easybuild-easyconfigs#3655)...