Skip to content

fix --list-software by making letter_dir_for aware of '*' wildcard name#1969

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_letter_dir_for
Oct 27, 2016
Merged

fix --list-software by making letter_dir_for aware of '*' wildcard name#1969
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_letter_dir_for

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 26, 2016

--list-software is broken in develop without this, only easyconfig files in the 0 subdir are taken into account.

The tests didn't notice this because the easyconfig files in test/framework/easyconfigs are organised differently than the ones in the easybuild-easyconfigs repository. I'll look into how much of a PITA it is to reorganise the easyconfigs there to match the directory structure we have in the easybuild-easyconfigs repository.

This was introduced in #1954.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 27, 2016

@wpoely86 please review?

a PR that reorganises the test easyconfigs to trigger the broken --list-software is available at #1970

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 27, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit b0ef380 into easybuilders:develop Oct 27, 2016
@boegel boegel deleted the fix_letter_dir_for branch October 27, 2016 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants