ingest vsc-base & vsc-install by boegel · Pull Request #2708 · easybuilders/easybuild-framework

boegel · 2018-12-27T11:15:45Z

This set of changes basically ingests vsc-base & vsc-install into the EasyBuild framework, either by copying the modules from the vsc.utils namespace into easybuild.base, or by copying the functionality into an existing module in the easybuild.tools namespace.

As such, this effectively removes vsc-base and vsc-install as dependencies.

I tried to only make minimal changes to the code being copied in, this is mostly about making the EasyBuild framework independent from vsc-base, not about also cleaning up that code. Therefore, any complaints made by Hound CI will be ignored.
I did strip out a bunch of code from the vsc-base modules that is currently not required by the EasyBuild framework.

Once this change is merged, we can start working on making EasyBuild compatible with Python 3.

Note that the target branch here is 4.x (which was forked from the current develop branch), so these changes will only be included in EasyBuild 4.0.
It's quite likely there will be one or more 3.x releases (e.g. 3.8.1, 3.9.0) before 4.0 is released.

The current develop branch remains the right place for changes that should be included in the next EasyBuild (3.x) release. I'll keep an eye on merging develop into the 4.x branch on a regular basis.

…nality from easybuild.base.missing

…d.tools.systemtools

…from easybuild.base.missing

…tilities

….config

boegel · 2018-12-28T09:39:34Z

Some further clarification w.r.t. my motivation to ingest vsc-base (as requested by @wpoely86):

It helps with working towards Python 3 compatibility because:
- Not depending on vsc-base anymore means that we can work on Python 3 compatibility on our own pace. Porting vsc-base to Python 3 will have to be done with great care because it's a dependency for a whole bunch of scripts & tools inside of HPC-UGent, including a bunch of private repositories, so that process will be slow (and it has barely started).
- A significant amount of code that is not required by EasyBuild was stripped out when ingesting vsc-base, so there's less code to port to Python 3.
No longer depending on vsc-base means that we can also look into getting rid of setuptools as a dependency for EasyBuild. Since setuptools is also required for vsc-base itself (to define the vsc namespace that is spread across multiple directories), this is only possible without depending on vsc-base.
If we manage to also drop setuptools as a dependency, there are no Python packages not included in the Python standard library that we require (although there are still several optional dependencies that are only required for specific functionality).

wpoely86 · 2018-12-29T10:13:09Z

-        "vsc-install >= 0.9.19",
-        "vsc-base >= 2.5.8",
-    ],
+    install_requires=['setuptools >= 0.6'],


so where are we still using it?

setuptools is still used for now, yes, that needs more work

wpoely86 · 2018-12-29T10:13:55Z

It's big but I didn't find anything that caught my attention.

itkovian · 2019-01-14T10:58:12Z

+
+
+class LoggedException(Exception):
+    """Exception that logs it's message when it is created."""


boegel added 18 commits December 19, 2018 19:37

don't install vsc-base as dep in Travis config

eee183a

ingest vsc-base into easybuild.base namespace + remove unused functio…

5ac43c1

…nality from easybuild.base.missing

bump version in bootstrap script

7701708

remove vsc-install and vsc-base dependencies from setup.py

510d865

revert changes to bootstrap script which still installs EasyBuild v3.x

4fb27ce

strip down easybuild.base.affinity

05cf287

merge required functionality of easybuild.base.affinity into easybuil…

67db46e

…d.tools.systemtools

drop support for date/datetime-typed options in GeneralOption

7993e14

remove unused PassThroughOptionParser from easybuild.base.generaloption

d120141

merge mk_rst_table function into easybuild.tools.docs

9adc790

use own implementation of shell_quote rather than the implementation …

f168225

…from easybuild.base.missing

collapse functions from easybuild.base.missing into easybuild.tools.u…

382805f

…tilities

fix broken test_setvar

f85cd00

merge Singleton class into easybuild.tools.config

8a39261

fix cyclic import by moving GENERAL_CLASS constant to easybuild.tools…

37af92f

….config

fix import for Singleton in test/framework/utilities.py

8662e71

fix import for GENERAL_CLASS constant in test/framework/utilities.py

5d0f18d

strip down easybuild.base.testing

a79de84

boegel added the change label Dec 27, 2018

boegel added this to the 4.0 milestone Dec 27, 2018

houndci-bot reviewed Dec 27, 2018

View reviewed changes

fix trivial style issues

4fc59e8

wpoely86 approved these changes Dec 29, 2018

View reviewed changes

wpoely86 merged commit 89438bd into easybuilders:4.x Dec 29, 2018

boegel deleted the ingest_vsc_base branch December 30, 2018 09:46

This was referenced Jan 10, 2019

EB bootstrap fails: Installed distribution setuptools 0.9.8 conflicts with requirement setuptools>=17.1 #2712

Closed

move mk_rst_table function from easybuild.tools.docs to easybuild.tools.utilities #2713

Merged

boegel added the python3 Python 3 compatibility label Jan 11, 2019

itkovian reviewed Jan 14, 2019

View reviewed changes

This was referenced Jan 24, 2019

support Python 3.x #133

Closed

EasyBuild v4.0 easybuilders/easybuild#447

Closed

boegel mentioned this pull request Feb 1, 2019

logging to stdout when using 4.x branch #2745

Closed

boegel mentioned this pull request Feb 27, 2019

put fake 'vsc' namespace in place that produces an error on import #2790

Merged

boegel mentioned this pull request May 8, 2019

vsc-base cannot be installed in virtualenv. It tries to copy files to central python installation #2867

Closed

boegel mentioned this pull request May 21, 2019

stick to vsc-base<2.9.0 in bootstrap script to avoid requiring 'future' dependency #2892

Merged

boegel mentioned this pull request Jun 18, 2019

only require vsc-base for EasyBuild 2.x and 3.x in EasyBuildMeta easyblock easybuilders/easybuild-easyblocks#1757

Merged



		class LoggedException(Exception):
		"""Exception that logs it's message when it is created."""

Conversation

boegel commented Dec 27, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

boegel commented Dec 28, 2018

Uh oh!

wpoely86 Dec 29, 2018

Choose a reason for hiding this comment

Uh oh!

boegel Dec 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpoely86 commented Dec 29, 2018

Uh oh!

itkovian Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

boegel Dec 29, 2018 •

edited

Loading