Skip to content

move mk_rst_table function from easybuild.tools.docs to easybuild.tools.utilities#2713

Merged
wpoely86 merged 3 commits intoeasybuilders:4.xfrom
boegel:move_mk_rst_table
Jan 11, 2019
Merged

move mk_rst_table function from easybuild.tools.docs to easybuild.tools.utilities#2713
wpoely86 merged 3 commits intoeasybuilders:4.xfrom
boegel:move_mk_rst_table

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 10, 2019

mk_rst_table was thrown into easybuild.tools.docs when ingesting vsc-base (see #2708), but that causes some problems because it's needed in easybuild.base.generaloption when porting the modules in the easybuild.base namespace to Python 3 as a first step

It'll be easier to have mk_rst_table parked in easybuild.tools.utilities for now, and keep easybuild.base more isolated from easybuild.tools (only easybuild.tools.utilities is required by easybuild.base.* after this change)

…ls.utilities to avoid importing easybuild.tools.docs from easybuild.base.generaloption
@boegel boegel added the change label Jan 10, 2019
@boegel boegel added this to the 4.0 milestone Jan 10, 2019
@boegel boegel requested a review from wpoely86 January 10, 2019 21:23
Comment thread easybuild/tools/utilities.py
Comment thread easybuild/framework/easyconfig/format/format.py Outdated
@wpoely86 wpoely86 merged commit 45cd56e into easybuilders:4.x Jan 11, 2019
@boegel boegel deleted the move_mk_rst_table branch January 11, 2019 09:43
@boegel boegel added python3 Python 3 compatibility and removed python3 Python 3 compatibility labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change python3 Python 3 compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants