Skip to content

enhance 'eb' command to ensure that easybuild.main can be imported before settling on python* command to use#3610

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:eb_enhancements
Mar 15, 2021
Merged

enhance 'eb' command to ensure that easybuild.main can be imported before settling on python* command to use#3610
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:eb_enhancements

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 14, 2021

This is a small enhancement for the eb command: only accepted the python* command if it's able to import easybuild.main.

This fixes the following strange/confusing situation, which occurs currently because eb considers python before python3 (unless $EB_PYTHON is set):

# default Python command is Python 2
$ python -V
Python 2.7.18

# use pip3 to install EasyBuild, with the intention to run it via 'python3'
$ pip3 install easybuild

# try running 'eb' fails because default 'python' command is not Python 3
$ eb --version
/usr/bin/python: No module named easybuild

@boegel boegel added this to the next release (4.3.4?) milestone Mar 14, 2021
akesandgren
akesandgren approved these changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Mar 15, 2021

Going in, thanks @boegel!

@akesandgren akesandgren merged commit d6fd180 into easybuilders:develop Mar 15, 2021
@boegel boegel deleted the eb_enhancements branch March 15, 2021 18:19
@bartoldeman bartoldeman mentioned this pull request Apr 8, 2022
Open
bartoldeman added a commit to ComputeCanada/easybuild-framework that referenced this pull request Apr 19, 2022
@bartoldeman
Change 'eb' command to import easybuild to check if it's working.
2a0c5c3 
This is a much cheaper test than "import easybuild.main" and still
solves the same issue as easybuilders#3610.

This reduces the wall time for "eb --version" from 1.35s to 0.73s
in our configuration.
@bartoldeman bartoldeman mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @akesandgren