change 'eb' command to import easybuild to check if it's working#3995
Conversation
This is a much cheaper test than "import easybuild.main" and still solves the same issue as easybuilders#3610. This reduces the wall time for "eb --version" from 1.35s to 0.73s in our configuration.
|
See also #3180 |
There was a problem hiding this comment.
Looks good to me. I've installed from the feature branch, and tested timings. For me it was about 25% faster to run eb --version. I've also tested a basic installation (which worked fine) just as a sanity check, even though this PR shouldn't change anything that could affect installations - only the check for which python to use was touched.
To me, the change looks sane and should still return the correct Python, namely the one used to install EasyBuild.
Requested changes were implemented
|
This is actually not equivalent at all, since if somehow only the |
|
An alternative could be to test the import of Follow-up PR at #3998 |
This is a much cheaper test than
import easybuild.mainand stillsolves the same issue as #3610.
This reduces the wall time for
eb --versionfrom 1.35s to 0.73sin our configuration.