also take /etc/os-release into account in get_os_name and get_os_version#3930
Merged
SebastianAchilles merged 3 commits intoeasybuilders:developfrom Jan 18, 2022
Merged
Conversation
SebastianAchilles
requested changes
Jan 18, 2022
SebastianAchilles
requested changes
Jan 18, 2022
Member
SebastianAchilles
left a comment
There was a problem hiding this comment.
To fix UnboundLocalError: local variable 'os_version' referenced before assignment
Co-authored-by: SebastianAchilles <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For recent Python versions, where
platform.linux_distributionis no longer available, we're not getting useful info on OS name/version unless the 3rd partydistropackage is installed.Falling back to
/etc/os-releaselargely fixes that...