Skip to content

fix get_os_name and get_os_version to avoid reporting UNKNOWN in output of eb --show-system-info #3942

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:sa-get-os-name
Jan 26, 2022
Merged

fix get_os_name and get_os_version to avoid reporting UNKNOWN in output of eb --show-system-info #3942
ocaisa merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:sa-get-os-name

Conversation

@SebastianAchilles
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles commented Jan 25, 2022

Currently UNKONWN is returned in get_os_name even if os_name can be found:

$ eb --show-system | grep name
  -> name: UNKNOWN
  -> platform name: x86_64-unknown-linux

I overlooked this when I merged #3930. This PR removes the no longer needed else condition.

@SebastianAchilles SebastianAchilles added this to the release after 4.5.2 milestone Jan 25, 2022
@ocaisa ocaisa merged commit f3d7cbe into easybuilders:develop Jan 26, 2022
@boegel boegel changed the title Fix get_os_name and get_os_version fix get_os_name and get_os_version to avoid reporting UNKNOWN in output of eb --show-system-info Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

@boegel boegel Awaiting requested review from boegel

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

2 participants

@SebastianAchilles @ocaisa