Skip to content

skip GitPython 3.1.28, since it prints 'git' as version which messes up the version check in check_github()#4090

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:GitPython_version_mess
Oct 10, 2022
Merged

skip GitPython 3.1.28, since it prints 'git' as version which messes up the version check in check_github()#4090
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:GitPython_version_mess

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 10, 2022

Temporary workaround for hard crash when running eb --check-github:

Checking status of GitHub integration...

Making sure we're online...OK

* GitHub user...easybuild_test => OK
* GitHub token...(no token found) => FAIL
* git command...OK ("git version 2.37.3; ")
* GitPython module...OK (GitPython version git)

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmp/runner/27071ea6b2f01bb01ec8a4fe1b156b7ac26b2654/lib/python3.7/site-packages/easybuild/main.py", line 602, in <module>
    main()
  File "/tmp/runner/27071ea6b2f01bb01ec8a4fe1b156b7ac26b2654/lib/python3.7/site-packages/easybuild/main.py", line 287, in main
    check_github()
  File "/tmp/runner/27071ea6b2f01bb01ec8a4fe1b156b7ac26b2654/lib/python3.7/site-packages/easybuild/tools/github.py", line 2089, in check_github
    if LooseVersion(ver) < LooseVersion(req_ver):
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/distutils/version.py", line 52, in __lt__
    c = self._cmp(other)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/distutils/version.py", line 337, in _cmp
    if self.version < other.version:
TypeError: '<' not supported between instances of 'str' and 'int'
* push access to easybuild_test/easybuild-easyconfigs repo @ GitHub...

@boegel boegel added this to the next release (4.6.2?) milestone Oct 10, 2022
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 10, 2022

I've reported this problem upstream at gitpython-developers/GitPython#1500 .

Regardless, we should probably make the code in check_github() a bit more robust, in case we're hitting a non-digit GitPython version...

@boegel boegel mentioned this pull request Oct 10, 2022
Merged
branfosj
branfosj approved these changes Oct 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj branfosj merged commit afa8cdb into easybuilders:develop Oct 10, 2022
@boegel boegel deleted the GitPython_version_mess branch October 10, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix tests

Projects

None yet

Milestone

4.6.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @branfosj