Skip to content

make sure that GitPython version is a proper version before checking minimal required version#4091

Merged
lexming merged 2 commits intoeasybuilders:developfrom
boegel:more_robust_gitpython_version_check
Oct 11, 2022
Merged

make sure that GitPython version is a proper version before checking minimal required version#4091
lexming merged 2 commits intoeasybuilders:developfrom
boegel:more_robust_gitpython_version_check

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 10, 2022

(includes commit that does workaround from #4090 + rollback of that workaround)

Proper fix for hard crash with eb --check-github when GitPython 3.1.28 is installed (see also gitpython-developers/GitPython#1500).

@boegel boegel added the bug fix label Oct 10, 2022
@boegel boegel added this to the next release (4.6.2?) milestone Oct 10, 2022
@boegel boegel requested a review from lexming October 11, 2022 07:20
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 11, 2022

Going in, thanks @boegel !

@lexming lexming merged commit 439159a into easybuilders:develop Oct 11, 2022
@boegel boegel deleted the more_robust_gitpython_version_check branch October 11, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants