fix configuration issues, in particular backwards compatibility + add config unit tests#556
Conversation
|
@ajdecon: This pull request should fix the problems you ran into. |
There was a problem hiding this comment.
first comment is about cosmetic aspects but, notice how DEFAULT_MODULECLASSES has a K&R style,
meanwhile much else has a more arbitrary indentation level depending on the length of the variable name?
In fact, I think that either should be improved: use of 2, 4 or 8 fixed indenting spaces improves readability without imposing artificial competition between a variable name's length and the content assigned (think of "description" here at 120chars) plus, the closing bracket should be placed in a consistent manner, to help signify the block level when multiple nesting is occurring.
This comment could potentially trigger much decorative improvements, so handle it only as such: just consider it and come back as needed.
|
OK, in a diagonal check I think this is ready for merging in - I confess having not tried it practice (that would be too much of a surgery for me for a Sunday :-) In the meantime, can we provide a parameter, for future use, that will allow to control the subdirectory where the "compiler", "base", "lib" moduleclasses end up? That would be needed to make it possible to have a modulefile namespace like the one visible at: https://wickie.hlrs.de/platforms/index.php/Module_Overview |
|
@fgeorgatos: Fix your style remark (only in W.r.t. the request for a parameter to control the dir where the module classes directories end up: does |
|
@stdweird: Removed the unneeded old-style prefix related stuff as discussed, unit tests still pass. |
There was a problem hiding this comment.
shouldn't values such as build come from the config.DEFAULT_PATH_SUBDIRS.
|
@boegel onlye one remark, not sure what is the best to do there, but rest looks fine |
|
All remarks fixed, this is now really only refactoring + unit tests. |
|
@boegel looks fine by me |
fix configuration issues, in particular backwards compatibility + add config unit tests
This pull request fixes a couple of configuration problems introduced by #529, in particular backwards compatibility ('old-style' configuration), and the use of
--prefixthat resulted inKeyErrorexceptions.A couple of unit tests that mainly test the default configuration using
$HOME/.local/easybuildand legacy configuration options (both environment variables like$EASYBUILDPREFIXand co and config files$HOME/.easybuild/config.pyand using$EASYBUILDCONFIG).