Skip to content

config unittests and bugfix#559

Merged
boegel merged 12 commits intoeasybuilders:developfrom
stdweird:fix_legacy_prefix
Mar 25, 2013
Merged

config unittests and bugfix#559
boegel merged 12 commits intoeasybuilders:developfrom
stdweird:fix_legacy_prefix

Conversation

@stdweird
Copy link
Copy Markdown
Contributor

introduce other config unittests, fix bug

@stdweird
Copy link
Copy Markdown
Contributor Author

@boegel although your #556 unittests look more complete, this check basic functionality for ol and new configuration (and fixes one bug for newstyle). we should discuss on merging them

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2013

I propose I clean up #556 to merge it in, and I'll then handle this pull request to resolve the conflicts that it will produce (i.e., join your and my config.py).

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2013

Reworked this on top of #556 (which should be merged in first!), see stdweird#18.

  • got rid of get_opts_config, used configure instead
  • got rid of test_legacy_opts, integrated missing tests (new vs old style) in test_legacy_env_vars
  • rely on setUp and tearDown
  • refactoring w.r.t. style
  • fixed another bug (?) along the way, i.e. rename args used in config.init to dance around error:
Traceback (most recent call last):
  File "easybuild/test/config.py", line 347, in test_generaloption_config
    opts, evars = self.get_opts_config(args=args)
  File "easybuild/test/config.py", line 76, in get_opts_config
    config.init(options, eb_go.get_options_by_section('config'))
  File "/Users/kehoste/.local/lib/python2.7/site-packages/easybuild_framework-1.3.0dev-py2.7.egg/easybuild/tools/config.py", line 306, in init
    (options.repository, repo.__name__, args, err))
NameError: global name 'args' is not defined

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2013

All unit tests pass in this branch on my end:

$ python -m easybuild.test.suite
.............................................................
----------------------------------------------------------------------
Ran 61 tests in 206.756s

OK

@stdweird
Copy link
Copy Markdown
Contributor Author

@boegel merged your PR, fixed some small issues. all unittests

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2013

Looks great, merging it in!

boegel added a commit that referenced this pull request Mar 25, 2013
@boegel boegel merged commit b51637c into easybuilders:develop Mar 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants