Closed
Conversation
Contributor
|
Thanks for your work! Could you please improve your commit message. Have a look at our README and this great writeup: https://chris.beams.io/posts/git-commit/ |
ilya-khadykin
approved these changes
Oct 3, 2017
Contributor
There was a problem hiding this comment.
This is an important addition, thanks.
Commit message can be improved as @behrtam suggested to follow best practices
Contributor
|
Actually, I'm going to create an issue for each exercise to add topics if missing and I'll hold on to merge this until then |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roman Numerals: Adds topics to config.json for the mentioned question
The given exercise would include logic and mathematics to convert the given integer into a set of Roman Numerals that would form the complete number. This would further require String Manipulation and text formatting to attain the final answer.
This commit hence, adds four fields under topics:
Resolves: issue #826