Add topics to roman-numerals exercise#943
Merged
ilya-khadykin merged 2 commits intoexercism:masterfrom Oct 17, 2017
rtfoley:828-roman-numerals-topics
Merged
Add topics to roman-numerals exercise#943ilya-khadykin merged 2 commits intoexercism:masterfrom rtfoley:828-roman-numerals-topics
ilya-khadykin merged 2 commits intoexercism:masterfrom
rtfoley:828-roman-numerals-topics
Conversation
Contributor
ilya-khadykin
left a comment
There was a problem hiding this comment.
Thanks for the PR
I would like hear your thoughts regarding my comment
config.json
Outdated
| "loops", | ||
| "integers", | ||
| "strings", | ||
| "maps", |
Contributor
There was a problem hiding this comment.
Hm, this is interesting. <class 'dict'> in Python is an essence a Map, but newcomers might not even realize it.
Thoughts?
I guess we can leave it
Contributor
Author
There was a problem hiding this comment.
That was my original thinking, that newcomers would be thinking "map" from other languages, so it might help with the transition. Thinking about it more, perhaps best to remove it to avoid confusion with the Map function.
Contributor
|
Thanks, @rtfoley 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add topics to roman-numerals exercise.
Fixes #828