feat: Add Oracle DB as Offline store in python sdk & operator#6017
feat: Add Oracle DB as Offline store in python sdk & operator#6017ntkathole merged 40 commits intofeast-dev:masterfrom
Conversation
|
@aniketpalu Tested oracle DB configuration with feast operator and feast SDK , LGTM |
de7b133 to
79b59da
Compare
sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py
Outdated
Show resolved
Hide resolved
sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py
Outdated
Show resolved
Hide resolved
sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py
Outdated
Show resolved
Hide resolved
sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py
Outdated
Show resolved
Hide resolved
|
|
||
| def _read_data_source(data_source: DataSource, repo_path: str = "") -> Table: | ||
| table = _read_oracle_table(con, data_source) | ||
| return ibis.memtable(table.execute()) |
There was a problem hiding this comment.
reading entire table in memory? Isn't there a better way to read filtered table based on timestamps may be?
There was a problem hiding this comment.
pretty sure _build_data_source_reader_for_retrieval function is completely redundant, it just repackages _build_data_source_reader for no good reason.
There was a problem hiding this comment.
Added pre-filter to avoid reading the whole table. Thanks for the catch
There was a problem hiding this comment.
to be clear, I don't understand why we need _build_data_source_reader_for_retrieval at all. can't you use _build_data_source_reader in get_historical_features_ibis call? that way there will be no materialization
There was a problem hiding this comment.
Thanks for clarification, I misunderstood your earlier comment. You are right, materialization can be avoided by using _build_data_source_reader.
After this fix, needed to do a little change in building entity_row_id in ibis as r = ibis.literal("") in _generate_row_id() creates broken entity_row_id due to Oracle DB casting it as NULL.
sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py
Show resolved
Hide resolved
|
Can we add documentation as well for offline store ? |
d8c2abb to
4fffb65
Compare
|
@aniketpalu Need rebase |
ecc47ac to
9b363eb
Compare
9b363eb to
ecc47ac
Compare
…-operator Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
… Vulnerability Signed-off-by: Aniket Paluskar <[email protected]>
…s & validation for mutually exclusive fields Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
…0 EnumTypeWrapper incompatibility Signed-off-by: Aniket Paluskar <[email protected]>
Srihari1192
left a comment
There was a problem hiding this comment.
Tested the changes LGTM
Thanks @aniketpalu
…oid runtime errors Signed-off-by: Aniket Paluskar <[email protected]>
sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Aniket Paluskar <[email protected]>
…value in Oracle DB Signed-off-by: Aniket Paluskar <[email protected]>
… ibis date32[day] Arrow mapping Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
Signed-off-by: Aniket Paluskar <[email protected]>
ff2104a to
466e2d2
Compare
Signed-off-by: Aniket Paluskar <[email protected]>
ntkathole
left a comment
There was a problem hiding this comment.
looks good! Thanks @aniketpalu
…dev#6017) * feat: Add Oracle DB as Offline store in python sdk & support in feast-operator Signed-off-by: Aniket Paluskar <[email protected]> * Added oracle db dependency from ibis-framework subgroups Signed-off-by: Aniket Paluskar <[email protected]> * Operator yaml changes Signed-off-by: Aniket Paluskar <[email protected]> * Data source writer ignored parameters, fixed Signed-off-by: Aniket Paluskar <[email protected]> * Replaced raw sql with dedicated truncate_table() to fix SQL Injection Vulnerability Signed-off-by: Aniket Paluskar <[email protected]> * Minor improvements like single db connection, removal of default creds & validation for mutually exclusive fields Signed-off-by: Aniket Paluskar <[email protected]> * Fetching pre-filtered table from db Signed-off-by: Aniket Paluskar <[email protected]> * Minor formatting changes Signed-off-by: Aniket Paluskar <[email protected]> * Added Oracle DB Offline Store documentation Signed-off-by: Aniket Paluskar <[email protected]> * Resolved import error by removing OracleSource import from the __init__ Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error by updating secret baseline Signed-off-by: Aniket Paluskar <[email protected]> * fix: Exclude qdrant from docstring tests to avoid qdrant-client 1.17.0 EnumTypeWrapper incompatibility Signed-off-by: Aniket Paluskar <[email protected]> * Generated secret.baseline to avoid lint error Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secrets.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Update sdk/python/feast/type_map.py Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Aniket Paluskar <[email protected]> * Updated dependency lock files Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issues in Trino Offline Store Signed-off-by: Aniket Paluskar <[email protected]> * Updated requirements Signed-off-by: Aniket Paluskar <[email protected]> * Updated pixi.lock file Signed-off-by: Aniket Paluskar <[email protected]> * Restricted non-empty feature_views in get_historical_features() to avoid runtime errors Signed-off-by: Aniket Paluskar <[email protected]> * Removed _build_data_source_reader_for_retrieval function Signed-off-by: Aniket Paluskar <[email protected]> * Modified initial query to be _ to avoid empty string casting to Null value in Oracle DB Signed-off-by: Aniket Paluskar <[email protected]> * cast DATE to TIMESTAMP in _read_oracle_table to preserve time lost by ibis date32[day] Arrow mapping Signed-off-by: Aniket Paluskar <[email protected]> * Use single database connection for pull_latest_from_table_or_query() Signed-off-by: Aniket Paluskar <[email protected]> * Improved readibility by breaking down the code into functions Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline and pixi.lock Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issue Signed-off-by: Aniket Paluskar <[email protected]> --------- Signed-off-by: Aniket Paluskar <[email protected]> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Shizoqua <[email protected]>
…dev#6017) * feat: Add Oracle DB as Offline store in python sdk & support in feast-operator Signed-off-by: Aniket Paluskar <[email protected]> * Added oracle db dependency from ibis-framework subgroups Signed-off-by: Aniket Paluskar <[email protected]> * Operator yaml changes Signed-off-by: Aniket Paluskar <[email protected]> * Data source writer ignored parameters, fixed Signed-off-by: Aniket Paluskar <[email protected]> * Replaced raw sql with dedicated truncate_table() to fix SQL Injection Vulnerability Signed-off-by: Aniket Paluskar <[email protected]> * Minor improvements like single db connection, removal of default creds & validation for mutually exclusive fields Signed-off-by: Aniket Paluskar <[email protected]> * Fetching pre-filtered table from db Signed-off-by: Aniket Paluskar <[email protected]> * Minor formatting changes Signed-off-by: Aniket Paluskar <[email protected]> * Added Oracle DB Offline Store documentation Signed-off-by: Aniket Paluskar <[email protected]> * Resolved import error by removing OracleSource import from the __init__ Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error by updating secret baseline Signed-off-by: Aniket Paluskar <[email protected]> * fix: Exclude qdrant from docstring tests to avoid qdrant-client 1.17.0 EnumTypeWrapper incompatibility Signed-off-by: Aniket Paluskar <[email protected]> * Generated secret.baseline to avoid lint error Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secrets.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Update sdk/python/feast/type_map.py Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Aniket Paluskar <[email protected]> * Updated dependency lock files Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issues in Trino Offline Store Signed-off-by: Aniket Paluskar <[email protected]> * Updated requirements Signed-off-by: Aniket Paluskar <[email protected]> * Updated pixi.lock file Signed-off-by: Aniket Paluskar <[email protected]> * Restricted non-empty feature_views in get_historical_features() to avoid runtime errors Signed-off-by: Aniket Paluskar <[email protected]> * Removed _build_data_source_reader_for_retrieval function Signed-off-by: Aniket Paluskar <[email protected]> * Modified initial query to be _ to avoid empty string casting to Null value in Oracle DB Signed-off-by: Aniket Paluskar <[email protected]> * cast DATE to TIMESTAMP in _read_oracle_table to preserve time lost by ibis date32[day] Arrow mapping Signed-off-by: Aniket Paluskar <[email protected]> * Use single database connection for pull_latest_from_table_or_query() Signed-off-by: Aniket Paluskar <[email protected]> * Improved readibility by breaking down the code into functions Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline and pixi.lock Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issue Signed-off-by: Aniket Paluskar <[email protected]> --------- Signed-off-by: Aniket Paluskar <[email protected]> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Aniket Paluskar <[email protected]>
…dev#6017) * feat: Add Oracle DB as Offline store in python sdk & support in feast-operator Signed-off-by: Aniket Paluskar <[email protected]> * Added oracle db dependency from ibis-framework subgroups Signed-off-by: Aniket Paluskar <[email protected]> * Operator yaml changes Signed-off-by: Aniket Paluskar <[email protected]> * Data source writer ignored parameters, fixed Signed-off-by: Aniket Paluskar <[email protected]> * Replaced raw sql with dedicated truncate_table() to fix SQL Injection Vulnerability Signed-off-by: Aniket Paluskar <[email protected]> * Minor improvements like single db connection, removal of default creds & validation for mutually exclusive fields Signed-off-by: Aniket Paluskar <[email protected]> * Fetching pre-filtered table from db Signed-off-by: Aniket Paluskar <[email protected]> * Minor formatting changes Signed-off-by: Aniket Paluskar <[email protected]> * Added Oracle DB Offline Store documentation Signed-off-by: Aniket Paluskar <[email protected]> * Resolved import error by removing OracleSource import from the __init__ Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error by updating secret baseline Signed-off-by: Aniket Paluskar <[email protected]> * fix: Exclude qdrant from docstring tests to avoid qdrant-client 1.17.0 EnumTypeWrapper incompatibility Signed-off-by: Aniket Paluskar <[email protected]> * Generated secret.baseline to avoid lint error Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint error Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secrets.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint errors Signed-off-by: Aniket Paluskar <[email protected]> * Update sdk/python/feast/type_map.py Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Aniket Paluskar <[email protected]> * Updated dependency lock files Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issues in Trino Offline Store Signed-off-by: Aniket Paluskar <[email protected]> * Updated requirements Signed-off-by: Aniket Paluskar <[email protected]> * Updated pixi.lock file Signed-off-by: Aniket Paluskar <[email protected]> * Restricted non-empty feature_views in get_historical_features() to avoid runtime errors Signed-off-by: Aniket Paluskar <[email protected]> * Removed _build_data_source_reader_for_retrieval function Signed-off-by: Aniket Paluskar <[email protected]> * Modified initial query to be _ to avoid empty string casting to Null value in Oracle DB Signed-off-by: Aniket Paluskar <[email protected]> * cast DATE to TIMESTAMP in _read_oracle_table to preserve time lost by ibis date32[day] Arrow mapping Signed-off-by: Aniket Paluskar <[email protected]> * Use single database connection for pull_latest_from_table_or_query() Signed-off-by: Aniket Paluskar <[email protected]> * Improved readibility by breaking down the code into functions Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline Signed-off-by: Aniket Paluskar <[email protected]> * Updated .secret.baseline and pixi.lock Signed-off-by: Aniket Paluskar <[email protected]> * Fixed lint issue Signed-off-by: Aniket Paluskar <[email protected]> --------- Signed-off-by: Aniket Paluskar <[email protected]> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: yuanjun220 <[email protected]>
# [0.61.0](v0.60.0...v0.61.0) (2026-04-07) ### Bug Fixes * Add grpcio dependency group to transformation server Dockerfile ([2c2150a](2c2150a)) * Add https readiness check for rest-registry tests ([ea85e63](ea85e63)) * Add website build check for PRs and fix blog frontmatter YAML error ([#6079](#6079)) ([30a3a43](30a3a43)) * Added missing jackc/pgx/v5 entries ([94ad0e7](94ad0e7)) * Added MLflow metric charts across feature selection ([#6080](#6080)) ([a403361](a403361)) * Check duplicate names for feature view across types ([#5999](#5999)) ([95b9af8](95b9af8)) * Fix integration tests ([#6046](#6046)) ([02d5548](02d5548)) * Fix missing error handling for resource_counts endpoint ([d9706ce](d9706ce)) * Fix non-specific label selector on metrics service ([a1a160d](a1a160d)) * fix path feature_definitions.py ([7d7df68](7d7df68)) * Fix regstry Rest API tests intermittent failure ([d53a339](d53a339)) * Fixed IntegrityError on SqlRegistry ([#6047](#6047)) ([325e148](325e148)) * Fixed intermittent failures in get_historical_features ([c335ec7](c335ec7)) * Fixed pre-commit check ([114b7db](114b7db)) * Fixed the intermittent FeatureViewNotFoundException ([661ecc7](661ecc7)) * Fixed uv cache permission error for docker build on mac ([ad807be](ad807be)) * Fixes a `PydanticDeprecatedSince20` warning for trino_offline_store ([#5991](#5991)) ([abfd18a](abfd18a)) * Handle existing RBAC role gracefully in namespace registry ([b46a62b](b46a62b)) * Ignore ipynb files during apply ([#6151](#6151)) ([4ea123d](4ea123d)) * Integration test failures ([#6040](#6040)) ([9165870](9165870)) * Mount TLS volumes for init container ([080a9b5](080a9b5)) * **postgres:** Use end_date in synthetic entity_df for non-entity retrieval ([#6110](#6110)) ([088a802](088a802)), closes [#6066](#6066) * Ray offline store tests are duplicated across 3 workflows ([54f705a](54f705a)) * Reenable tests ([#6036](#6036)) ([82ee7f8](82ee7f8)) * SSL/TLS mode by default for postgres connection ([4844488](4844488)) * Use commitlint pre-commit hook instead of a separate action ([35a81e7](35a81e7)) ### Features * Add Claude Code agent skills for Feast ([#6081](#6081)) ([1e5b60f](1e5b60f)), closes [#5976](#5976) [#6007](#6007) * Add complex type support (Map, JSON, Struct) with schema validation ([#5974](#5974)) ([1200dbf](1200dbf)) * Add decimal to supported feature types ([#6029](#6029)) ([#6226](#6226)) ([cff6fbf](cff6fbf)) * Add feast apply init container to automate registry population on pod start ([#6106](#6106)) ([6b31a43](6b31a43)) * Add feature view versioning support to PostgreSQL and MySQL online stores ([#6193](#6193)) ([940e0f0](940e0f0)), closes [#6168](#6168) [#6169](#6169) [#2728](#2728) * Add materialization, feature freshness, request latency, and push metrics to feature server ([2c6be18](2c6be18)) * Add metadata statistics to registry api ([ef1d4fc](ef1d4fc)) * Add non-entity retrieval support for ClickHouse offline store ([4d08ddc](4d08ddc)), closes [#5835](#5835) * Add OnlineStore for MongoDB ([#6025](#6025)) ([bf4e3fa](bf4e3fa)), closes [golang/go#74462](golang/go#74462) * Add Oracle DB as Offline store in python sdk & operator ([#6017](#6017)) ([9d35368](9d35368)) * Add RBAC aggregation labels to FeatureStore ClusterRoles ([daf77c6](daf77c6)) * Add ServiceMonitor auto-generation for Prometheus discovery ([#6126](#6126)) ([56e6d21](56e6d21)) * Add typed_features field to grpc write request (([#6117](#6117)) ([#6118](#6118)) ([eeaa6db](eeaa6db)), closes [#6116](#6116) * Add UUID and TIME_UUID as feature types ([#5885](#5885)) ([#5951](#5951)) ([5d6e311](5d6e311)) * Add version indicators to lineage graph nodes ([#6187](#6187)) ([73805d3](73805d3)) * Add version tracking to FeatureView ([#6101](#6101)) ([ed4a4f2](ed4a4f2)) * Added Agent skills for AI Agents ([#6007](#6007)) ([99008c8](99008c8)) * Added CodeQL SAST scanning and detect-secrets pre-commit hook ([547b516](547b516)) * Added odfv transformations metrics ([8b5a526](8b5a526)) * Adding optional name to Aggregation (feast-dev[#5994](#5994)) ([#6083](#6083)) ([56469f7](56469f7)) * Created DocEmbedder class ([#5973](#5973)) ([0719c06](0719c06)) * Extended OIDC support to extract groups & namespaces and token injection with multiple methods ([#6089](#6089)) ([7c04026](7c04026)) * Feature Server High-Availability on Kubernetes ([#6028](#6028)) ([9c07b4c](9c07b4c)), closes [Hi#Availability](https://github.com/Hi/issues/Availability) [Hi#Availability](https://github.com/Hi/issues/Availability) * **go:** Implement metrics and tracing for http and grpc servers ([#5925](#5925)) ([2b4ec9a](2b4ec9a)) * Horizontal scaling support to the Feast operator ([#6000](#6000)) ([3ec13e6](3ec13e6)) * Making feature view source optional (feast-dev[#6074](#6074)) ([#6075](#6075)) ([76917b7](76917b7)) * Replace ORJSONResponse with Pydantic response models for faster JSON serialization ([65cf03c](65cf03c)) * Support arm docker build ([#6061](#6061)) ([1e1f5d9](1e1f5d9)) * Support distinct count aggregation [[#6116](#6116)] ([3639570](3639570)) * Support HTTP in MCP ([#6109](#6109)) ([e72b983](e72b983)) * Support nested collection types (Array/Set of Array/Set) ([#5947](#5947)) ([#6132](#6132)) ([ab61642](ab61642)) * Support podAnnotations on Deployment pod template ([1b3cdc1](1b3cdc1)) * Use orjson for faster JSON serialization in feature server ([6f5203a](6f5203a)) * Utilize date partition column in BigQuery ([#6076](#6076)) ([4ea9b32](4ea9b32)) ### Performance Improvements * Online feature response construction in a single pass over read rows ([113fb04](113fb04)) * Optimize protobuf parsing in Redis online store ([#6023](#6023)) ([59dfdb8](59dfdb8)) * Optimize timestamp conversion in _convert_rows_to_protobuf ([33a2e95](33a2e95)) * Parallelize DynamoDB batch reads in sync online_read ([#6024](#6024)) ([9699944](9699944)) * Remove redundant entity key serialization in online_read ([d87283f](d87283f))
# [0.62.0](v0.61.0...v0.62.0) (2026-04-08) ### Bug Fixes * Added missing jackc/pgx/v5 entries ([94ad0e7](94ad0e7)) * Fix missing error handling for resource_counts endpoint ([d9706ce](d9706ce)) * fix path feature_definitions.py ([7d7df68](7d7df68)) * Fix regstry Rest API tests intermittent failure ([d53a339](d53a339)) * Fixed intermittent failures in get_historical_features ([c335ec7](c335ec7)) * Fixed the intermittent FeatureViewNotFoundException ([661ecc7](661ecc7)) * Handle existing RBAC role gracefully in namespace registry ([b46a62b](b46a62b)) * Ignore ipynb files during apply ([#6151](#6151)) ([4ea123d](4ea123d)) * Mount TLS volumes for init container ([080a9b5](080a9b5)) * **postgres:** Use end_date in synthetic entity_df for non-entity retrieval ([#6110](#6110)) ([088a802](088a802)), closes [#6066](#6066) * SSL/TLS mode by default for postgres connection ([4844488](4844488)) * Sync v0.61-branch so v0.61.0 tag is reachable from master ([af66878](af66878)) ### Features * Add Claude Code agent skills for Feast ([#6081](#6081)) ([1e5b60f](1e5b60f)), closes [#5976](#5976) [#6007](#6007) * Add decimal to supported feature types ([#6029](#6029)) ([#6226](#6226)) ([cff6fbf](cff6fbf)) * Add feast apply init container to automate registry population on pod start ([#6106](#6106)) ([6b31a43](6b31a43)) * Add feature view versioning support to PostgreSQL and MySQL online stores ([#6193](#6193)) ([940e0f0](940e0f0)), closes [#6168](#6168) [#6169](#6169) [#2728](#2728) * Add metadata statistics to registry api ([ef1d4fc](ef1d4fc)) * Add Oracle DB as Offline store in python sdk & operator ([#6017](#6017)) ([9d35368](9d35368)) * Add RBAC aggregation labels to FeatureStore ClusterRoles ([daf77c6](daf77c6)) * Add ServiceMonitor auto-generation for Prometheus discovery ([#6126](#6126)) ([56e6d21](56e6d21)) * Add typed_features field to grpc write request (([#6117](#6117)) ([#6118](#6118)) ([eeaa6db](eeaa6db)), closes [#6116](#6116) * Add UUID and TIME_UUID as feature types ([#5885](#5885)) ([#5951](#5951)) ([5d6e311](5d6e311)) * Add version indicators to lineage graph nodes ([#6187](#6187)) ([73805d3](73805d3)) * Add version tracking to FeatureView ([#6101](#6101)) ([ed4a4f2](ed4a4f2)) * Added Agent skills for AI Agents ([#6007](#6007)) ([99008c8](99008c8)) * Added odfv transformations metrics ([8b5a526](8b5a526)) * Created DocEmbedder class ([#5973](#5973)) ([0719c06](0719c06)) * Extended OIDC support to extract groups & namespaces and token injection with multiple methods ([#6089](#6089)) ([7c04026](7c04026)) * Replace ORJSONResponse with Pydantic response models for faster JSON serialization ([65cf03c](65cf03c)) * Support distinct count aggregation [[#6116](#6116)] ([3639570](3639570)) * Support HTTP in MCP ([#6109](#6109)) ([e72b983](e72b983)) * Support nested collection types (Array/Set of Array/Set) ([#5947](#5947)) ([#6132](#6132)) ([ab61642](ab61642)) * Support podAnnotations on Deployment pod template ([1b3cdc1](1b3cdc1)) * Utilize date partition column in BigQuery ([#6076](#6076)) ([4ea9b32](4ea9b32)) ### Performance Improvements * Online feature response construction in a single pass over read rows ([113fb04](113fb04))
What this PR does / why we need it:
Oracle DB Offline Store for Feast (ibis-based)
This PR adds a native Oracle Database offline store for Feast, built on the ibis-framework's Oracle backend (ibis.oracle). It follows the same proven pattern used by the existing MSSQL ibis offline store — delegating to the shared ibis.py functions for point-in-time joins, deduplication, and feature retrieval.
The implementation is ~300 lines total (vs 1096 lines in the SQLAlchemy-based approach), with no Jinja2 templates, no dialect-specific SQL workarounds, and no manual query generation. ibis generates Oracle SQL automatically and provides native Arrow transfer via to_pyarrow().
Oracle Column Name Handling
Oracle stores unquoted identifiers in UPPERCASE. For example, CREATE TABLE t (user_id INT) stores the column as USER_ID. This store uses a passthrough approach — column names are returned exactly as Oracle stores them, with no automatic case transformation.
This means:
Unquoted columns (the standard Oracle convention): The user references them in UPPERCASE, matching what they see in Oracle tools like SQL Developer, DBeaver, or DESCRIBE table.
Quoted columns (e.g., "CamelCase"): The user references them with the exact casing used when creating the table.
This design ensures predictable behavior — what you see in Oracle is what you use in Feast. No hidden transformations, no conventions to learn.
How to Use
feature_store.yamlWhat's Tested
Tested against a live Oracle 23ai database (Oracle Free 23.26.1.0.0):
Core Feast Operations:
Non-Entity Retrieval (entity_df=None):
Oracle Column Name Handling:
Which issue(s) this PR fixes:
#6018
Misc