Implement policy management in firewall-config#1540
Open
evyatark2 wants to merge 17 commits intofirewalld:mainfrom
Open
Implement policy management in firewall-config#1540evyatark2 wants to merge 17 commits intofirewalld:mainfrom
evyatark2 wants to merge 17 commits intofirewalld:mainfrom
Conversation
This will be a series of patches to implement policy management in the firewall-config gui tool. This first patch implements a policy view (both runtime and permenant) with the ability to change ingress/egress zones for each policy. It will will be very helpful if someone can write the various explanation labels as English isn't my first language.
06238ce to
0499565
Compare
…store for ingress/egress zones
It seems like there is a bedrock for the inversion of ICMP filters in a policy in the source code, but it isn't exposed. So I left the option to do so out for now
Additionaly, there is a toggle to show/hide the policies tab in the view menu
Author
|
I think this PR is ready. (except for the various explanations) |
Collaborator
|
Thank you!! This is a big PR and will take some time to review. Please be patient. |
Collaborator
I'm still trying to allocate time for this. Thank you for being patient. |
Author
|
I think it would be better to first review and merge #1542 since this PR sort of relies on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be a series of patches to implement policy management in the firewall-config gui tool.
This first patch implements a policy view (both runtime and permenant) with the ability to change ingress/egress zones for each policy.
It will will be very helpful if someone can write the various explanation labels as English isn't my first language.
Fixes #1281