Collapse some redundant stores into one#1542
Open
evyatark2 wants to merge 4 commits intofirewalld:mainfrom
Open
Collapse some redundant stores into one#1542evyatark2 wants to merge 4 commits intofirewalld:mainfrom
evyatark2 wants to merge 4 commits intofirewalld:mainfrom
Conversation
There were several GTK `ListStore`s that stored duplicated data. This patch gets rid of them. The result has several advantages: * Less memory usage and more performant code as traversals over the list only need to be executed when a service is modified * Easier management of service changes and immediate reflection of these changes in the UI when an asynchronous update is executed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were several GTK
ListStores that stored duplicated data. This patch gets rid of them.The result has several advantages: