Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Migrate to new pubspec plugins schema#2370

Closed
cyanglaz wants to merge 5 commits intoflutter:masterfrom
cyanglaz:rename_iosprefix
Closed

[video_player] Migrate to new pubspec plugins schema#2370
cyanglaz wants to merge 5 commits intoflutter:masterfrom
cyanglaz:rename_iosprefix

Conversation

@cyanglaz
Copy link
Copy Markdown
Contributor

@cyanglaz cyanglaz commented Dec 6, 2019

@cyanglaz cyanglaz requested a review from amirh December 6, 2019 23:56
Copy link
Copy Markdown
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should either land this without the web endorsement, or first add an android folder to the web plugin (if we do so we should bump the minimal required video_player_web)

@ditman
Copy link
Copy Markdown
Member

ditman commented Dec 10, 2019

(Merged here: #2389)

@ditman ditman closed this Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants