Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Endorse web implementation.#2389

Merged
ditman merged 1 commit intoflutter:masterfrom
ditman:endorse_video_player_web
Dec 10, 2019
Merged

[video_player] Endorse web implementation.#2389
ditman merged 1 commit intoflutter:masterfrom
ditman:endorse_video_player_web

Conversation

@ditman
Copy link
Copy Markdown
Member

@ditman ditman commented Dec 10, 2019

Description

This PR adds default support for web to the video_player plugin.

It also adds a minimal web example, so the example can be run through flutter run -d chrome.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ditman
Copy link
Copy Markdown
Member Author

ditman commented Dec 10, 2019

(Taking over #2370)

amirh
amirh approved these changes Dec 10, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman ditman merged commit 661d298 into flutter:master Dec 10, 2019
@ditman ditman deleted the endorse_video_player_web branch December 10, 2019 20:24
@ditman ditman mentioned this pull request Dec 10, 2019
Closed
@cyanglaz cyanglaz mentioned this pull request Dec 10, 2019
Closed
@kufel
Copy link
Copy Markdown

kufel commented Dec 11, 2019

C:\flutter\bin\flutter.bat --no-color packages get
Running "flutter pub get" in flutter...
The current Flutter SDK version is 1.9.1+hotfix.6.
Because app depends on video_player >=0.10.4+2 which requires Flutter SDK version >=1.10.0 <2.0.0, version solving failed.
pub get failed (1)
Process finished with exit code 1

epilo9er added a commit to COMANDKEYINC/flutter_plugins that referenced this pull request Dec 11, 2019
@epilo9er
Revert "[vide_player] Endorse web implementation. (flutter#2389)"
86c34b3 
This reverts commit 661d298.

# Conflicts:
#	packages/video_player/video_player/CHANGELOG.md
#	packages/video_player/video_player/pubspec.yaml
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@ditman
[vide_player] Endorse web implementation. (flutter#2389)
4ceb2b9 
* Adds default support for web to the video_player plugin
* Minimal `web` dir, so the example can be run through `flutter run -d chrome`
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@ditman
[vide_player] Endorse web implementation. (flutter#2389)
e44ff5d 
* Adds default support for web to the video_player plugin
* Minimal `web` dir, so the example can be run through `flutter run -d chrome`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harryterkelsen harryterkelsen Awaiting requested review from harryterkelsen

1 more reviewer

@amirh amirh amirh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ditman @kufel @amirh @googlebot