Skip to content

feat: Support DexGuard#684

Merged
bretthoerner merged 3 commits intogetsentry:masterfrom
myPinPad:master
Feb 27, 2019
Merged

feat: Support DexGuard#684
bretthoerner merged 3 commits intogetsentry:masterfrom
myPinPad:master

Conversation

@mpp-anasa
Copy link
Copy Markdown

@mpp-anasa mpp-anasa commented Feb 26, 2019

Sentry Android gradle plugin doesn't currently support DexGuard

This is because DexGuard doesn't use the same transformClasses steps as proguard.

When running with proguard, ./gradlew -m assembleRelease gives:

:app:preBuild SKIPPED
:app:extractProguardFiles SKIPPED
//....
:app:addSentryProguardSettingsForRelease SKIPPED
:app:processReleaseJavaRes SKIPPED
:app:transformResourcesWithMergeJavaResForRelease SKIPPED
:app:transformClassesAndResourcesWithProguardForRelease SKIPPED
:app:persistSentryProguardUuidsForRelease SKIPPED
:app:transformClassesWithDexForRelease SKIPPED
:app:transformClassesWithShrinkResForRelease SKIPPED
:app:mergeReleaseJniLibFolders SKIPPED
:app:transformNativeLibsWithMergeJniLibsForRelease SKIPPED
:app:transformNativeLibsWithStripDebugSymbolForRelease SKIPPED
:app:validateSigningRelease SKIPPED
//...

With DexGuard, the output of that command is:

:app:preBuild SKIPPED
:app:preReleaseBuild SKIPPED
//...
:app:transformClassesWithPreDexForRelease SKIPPED
:app:transformDexWithDexForRelease SKIPPED
:app:mergeReleaseJniLibFolders SKIPPED
:app:transformNativeLibsWithMergeJniLibsForRelease SKIPPED
:app:transformNativeLibsWithStripDebugSymbolForRelease SKIPPED
:app:processReleaseJavaRes SKIPPED
:app:transformResourcesWithMergeJavaResForRelease SKIPPED
:app:validateSigningRelease SKIPPED
:app:zipTempAssetsRelease SKIPPED
:app:setupDexguardRelease SKIPPED
:app:dexguardRelease SKIPPED

This PR simply makes the plugin look for the transformClassesWithPreDex and tranformDexWithDex for "dex" and "proguard" tasks, respectively.

@bretthoerner bretthoerner merged commit 08014a0 into getsentry:master Feb 27, 2019
@bretthoerner
Copy link
Copy Markdown

Thanks!

bretthoerner added a commit that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants