Closed
Conversation
|
No worries, I did |
Author
|
@bretthoerner Thanks! I was worried I had broken your SDK there... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes introduced in #684
It turns out that DexGuard doesn't use those tasks for
mapping.txtgeneration: rather, both the mapping and apk packaging are done within the samedexguard<VARIANT>task.The aforementioned approach only worked when there was a cached
mapping.txtpresent.Sorry about the confusion about this. I have opened a question on the sentry forum to figure out how to do this the correct way.
Apologies again