Skip to content

Remove shell injection in example#22568

Merged
lucascosti merged 3 commits intogithub:mainfrom
soliton-:patch-1
Dec 12, 2022
Merged

Remove shell injection in example#22568
lucascosti merged 3 commits intogithub:mainfrom
soliton-:patch-1

Conversation

@soliton-
Copy link
Copy Markdown
Contributor

@soliton- soliton- commented Dec 9, 2022 •
edited
Loading

Why:

Fixes code injection in shell code example

What's being changed (if available, include any code snippets, screenshots, or gifs):

Shell code example

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome bot commented Dec 9, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 9, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/creating-actions/dockerfile-support-for-github-actions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Dec 9, 2022

@soliton- Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 9, 2022
lucascosti
lucascosti previously approved these changes Dec 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, @soliton-! Just made a slight change and I'll get this merged in

@lucascosti lucascosti enabled auto-merge (squash) December 12, 2022 06:18
@lucascosti lucascosti merged commit 1390aa0 into github:main Dec 12, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 12, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

nitindudeja2107 referenced this pull request Dec 12, 2022
@hubwriter
Create github-debian.sh
b651227
nitindudeja2107 referenced this pull request Dec 12, 2022
@katelovescode
Update automatically-generated-release-notes.md
e6f1175 
clarifies exclusion configuration example
@lucascosti lucascosti mentioned this pull request Dec 13, 2022
Merged
2 tasks
@soliton- soliton- deleted the patch-1 branch December 13, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucascosti lucascosti lucascosti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soliton- @cmwilson21 @lucascosti