Skip to content

Fix Docker example errors and make it POSIX compliant#22635

Merged
lucascosti merged 1 commit intomainfrom
lucascosti/follow-up-22568
Dec 13, 2022
Merged

Fix Docker example errors and make it POSIX compliant#22635
lucascosti merged 1 commit intomainfrom
lucascosti/follow-up-22568

Conversation

@lucascosti
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti commented Dec 13, 2022 •
edited
Loading

Why:

Follows up #22568 to fix errors I made applying a comment (didn't replace the correct lines), and to implement @soliton-'s suggestions in this comment

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 13, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/creating-actions/dockerfile-support-for-github-actions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@lucascosti lucascosti merged commit 37644c8 into main Dec 13, 2022
@lucascosti lucascosti deleted the lucascosti/follow-up-22568 branch December 13, 2022 02:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@lucascosti lucascosti mentioned this pull request Dec 13, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martin389 martin389 martin389 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucascosti @martin389