Closed
Conversation
…nfowindow that pops up whenever the marker is clicked. The infowindow data has to be passed as a dict.
Author
|
Some of the added things were made by you but maybe aren't in the github, i used the .py that gets downloaded using pip. Also i changed a line on the init to make the coloricon compatible on windows. |
frslm
requested changes
Apr 27, 2020
gmplot/gmplot.py
Outdated
Comment on lines
-1
to
-16
| from __future__ import absolute_import | ||
|
|
||
| import json | ||
| import math | ||
| import os | ||
| import requests | ||
| import warnings | ||
|
|
||
| from collections import namedtuple | ||
|
|
||
| from gmplot.color_dicts import mpl_color_map, html_color_codes | ||
| from gmplot.google_maps_templates import SYMBOLS, CIRCLE | ||
|
|
||
|
|
||
| Symbol = namedtuple('Symbol', ['symbol', 'lat', 'long', 'size']) | ||
|
|
Contributor
There was a problem hiding this comment.
Seems very similar to the changes made in #93.
@jurrutiag if you could address the same comment I left there, I'd be more than happy to review and merge the label and info window changes here.
Contributor
|
Will close this as a duplicate of #119, since that PR allows users to pass in any HTML content for the InfoWindow, instead of a fixed list of key-value pairs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now a marker can have a label and an infowindow that pops up whenever the marker is clicked. The infowindow data has to be passed as a dict.